Mark argument as unused in optional.h #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annius
force-pushed
the
fix-unused-optional
branch
from
69ea628
to
a50afe1
Compare
Marks an unused argument in `optional.h` with `__attribute__((unused))`. The macro is defined as empty for Visual C++.
annius
force-pushed
the
fix-unused-optional
branch
from
a50afe1
to
9818188
Compare
jwellbelove
reviewed
Feb 24, 2018
There was a problem hiding this comment.
Actually, it seems that the returns for the nullopt operator overloads are back to front. I will change this at my end. Also I can see that optional is missing the full set of operators.
Can you make any further changes either on the development branch or a new 'bug fix' branch.
Thanks
John
|
Would you like me to close out this PR and create a new one into the devel branch? |
|
I'll close this pull request and work on updating the full set of operators for etl::optional. |
|
👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an unused parameter warning which is revealed when compiling a source that includes
optional.husingclang++-3.8.