-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use feature test macros instead of version checks #623
use feature test macros instead of version checks #623
Conversation
63a22dd
to
2e50416
Compare
2e50416
to
05104ed
Compare
I'm not sure how these can be used before C++20. |
As your link mentions, these feature test macros are only defined for compilers that support C++20 or above. Feature testing (since C++20) <<<<<< |
I have backported these feature test macros into Using these macros gives a better idea on what compiler features are required, and possibly extend the compiler support in case a compiler version only implements a subset of a C++ version (e.g. the current arm gcc C++20 version is missing a bunch of C++20 functionality, so just checking for the C++ version enables code sections that don't actually have compiler support yet. |
8196254
into
ETLCPP:feature/#623-use-feature-test-macros-instead-of-version-checks
* Update README.md * Update README.md * use feature test macros instead of version checks Co-authored-by: John Wellbelove <jwellbelove@users.noreply.github.com>
…-checks' of https://github.com/ETLCPP/etl into feature/#623-use-feature-test-macros-instead-of-version-checks # Conflicts: # include/etl/utility.h
I have started working on #572 myself, the branch is currently work in progress, so don't consider this a real PR at the moment, more of an indication that there's something being done in this direction.
My workflow is this:
git grep ETL_USING_CPP
ETL_USING_CPPxx
with the feature test macro, otherwise add a comment todetermine_compiler_language_support.h