-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake unittest cpp integration #68
Merged
jwellbelove
merged 18 commits into
ETLCPP:feature/CMake
from
scott-eddy:cmake-unittest-cpp-integration
Apr 24, 2018
Merged
Cmake unittest cpp integration #68
jwellbelove
merged 18 commits into
ETLCPP:feature/CMake
from
scott-eddy:cmake-unittest-cpp-integration
Apr 24, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g etl_profile.h, this will require some design changes as right now it is assumed a user will deine this profile when including ETL in their project
It is possible that the failures are correct or the profiles are not being setup correctly for them to actually pass. Will need input from other stakeholders
The hash errors look like the difference between 32 and 64 bit builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unittest as a git submodule from the project and instead adds it using CMake built-in utilities. In the case where a user has already installed UnitTest++ per their instructions this pulls in the library and headers using the provided
find_package()
utilities. In the case where the user hasn't installed UnitTest++ this uses CMake'sExternalProjectAdd()
to build the library.There are some issues with the I'm still working through but things are mostly there:
In particular interest is 4 listed above. When running all the tests on Linux I get the following output
These appear to actually be failures but could be the result of mismatched profiles.
Anyway, I wanted to get people looking at this PR sooner rather than later since it is a somewhat larger change.