Fix assumption that min/max macros will always be defined on a Microsoft compiler #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min
andmax
are not implicitly defined on MSVC, and the check performed inintegral_limits.h
can inadvertently define them in cases where they weren't already defined.Windows.h
is never included, they will not be defined.NOMINMAX
is defined before includingWindows.h
they will not be defined.Using
push_macro
andpop_macro
ensures they are restored to whatever state they were previously, while still allowing us to be sure they are undefined while evaluatingintegral_limits.h