New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSpecificationID instead of xxxxTestSpecificationID should be included in testable object definition #13

Closed

racheliurui opened this issue Aug 20, 2019 · 3 comments

Labels

duplicate ERDi MESA

Milestone

Discussed & Comme...

Collaborator

racheliurui commented Aug 20, 2019 •

edited by CharlieG021163

Loading

Refer to #10 where this issue and solution are part of the complete explanation and solution across all types. Duplicate with closed #14 and #15.

Background
In the B2MML, all instances of the XXXTestSpecificationID element should be changed to TestSpecificationID to align with updated 950002 Operations Test Model.
Also general use of TestSpecificationID aligns with the existing OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinitionType.
MESA may not do this solution. ERDi should.

Impacted Types and Solution
ERDi, MESA: MaterialClassType:
CHANGE: MaterialTestSpecificationID element
TO: TestSpecificationID

The following Types shall be changed similiarly:

MaterialDefinitionType/MaterialTestSpecificationID
MaterialLot/MaterialTestSpecificationID
EquipmentType/EquipmentCapabilityTestSpecificationID
EquipmentClassType/EquipmentCapabilityTestSpecificationID

racheliurui added ERDi MISA labels

racheliurui referenced this issue


          Update B2MML-Material.xsd

aaea7e2

ERDi only, Not MESA: complexType name = "MaterialClassType" / element name = "Version" is added ONLY to ERDI and NOT MESA version. This is a custom, non-95 standard attribute that will be standard only to ERDI implementation. Comment will be submitted to ISA-95 committee.

ERDi only, Not MESA: complexType name = "MaterialDefinitionType" / element name = "Version" is added ONLY to ERDI and NOT MESA version. This is a custom, non-95 standard attribute that will be standard only to ERDI implementation. Comment will be submitted to ISA-95 committee.

ERDi only, Not MESA: complexType name = "MaterialClassType", ADD element name = "EffectiveFrom" type = "DateTimeType" ONLY to ERDI and NOT MESA version. This is a custom, non-95 standard attribute that will be standard only to ERDI implementation. Comment will be submitted to ISA-95 committee.

ERDi only, Not MESA: complexType name = "MaterialClassType", ADD element name = "EffectiveTo" type = "DateTimeType" ONLY to ERDI and NOT MESA version. This is a custom, non-95 standard attribute that will be standard only to ERDI implementation. Comment will be submitted to ISA-95 committee.

ERDi only, Not MESA: complexType name = "MaterialDefinitionType", ADD element name = "EffectiveFrom" type = "DateTimeType" ONLY to ERDI and NOT MESA version. This is a custom, non-95 standard attribute that will be standard only to ERDI implementation. Comment will be submitted to ISA-95 committee.

ERDi only, Not MESA: complexType name = "MaterialDefinitionType", ADD element name = "EffectiveTo" type = "DateTimeType" ONLY to ERDI and NOT MESA version. This is a custom, non-95 standard attribute that will be standard only to ERDI implementation. Comment will be submitted to ISA-95 committee.

ERDi, MESA: complexType name = "MaterialClassType", CHANGED element name = "UsesPropertiesOfMaterialClassID" type = "IdentifierType" to "MaterialClassParentID" type = "MaterialClassIDType to align with updated ISA-95 Part 2 Material Class Object.

ERDi, MESA: MaterialInformationType: MaterialCapabilityTestSpecification should be deprecated and replaced by TestSpecification to align with updated Part 2, Operations Test Model. This also aligns with the OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition. MESA may not do. ERDi should.

ERDi, MESA: MaterialClassType: MaterialCapabilityTestSpecificationID should be deprecated and replaced by TestSpecificationID to align with updated Part 2, Operations Test Model. This also aligns with the OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition. MESA may not do. ERDi should.

ERDi, MESA: MaterialDefinitionType: MaterialCapabilityTestSpecificationID should be deprecated and replaced by TestSpecificationID to align with updated Part 2, Operations Test Model. This also aligns with the OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition. MESA may not do. ERDi should.

ERDi, MESA: MaterialLotType: MaterialCapabilityTestSpecificationID should be deprecated and replaced by TestSpecificationID to align with updated Part 2, Operations Test Model. This also aligns with the OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition. MESA may not do. ERDi should.

ERDi, MESA: MaterialSubLotType: ADD TestSpecificationID to align with updated Part 2, Operations Test Model. This also aligns with the OpMaterialRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition. MESA may not do. ERDi should.

ERDi, MESA: complexType name = "MaterialLotType", element name ="StorageLocation"; Change type = "StorageHierarchyScopeType" to "ResourceLocationType" to align with updated ISA-95 Part 2 Material Lot Object.

ERDi, MESA: complexType name = "MaterialSubLotType", element name ="StorageLocation"; Change type = "StorageHierarchyScopeType" to "ResourceLocationType" to align with updated ISA-95 Part 2 Material Sublot Object.

ERDi, MESA: complexType name = "MaterialPropertyType" / element name = "MaterialProperty". Change to "EquipmentPropertyChild" to align with ISA-95 Part 2 identified role name. Current element is not explicit about parent verses child.

ERDi, MESA: complexType name = "MaterialClassPropertyType" / element name = "MaterialClassProperty". Change to "MaterialClassPropertyChild" to align with ISA-95 Part 2 identified role name. Current element is not explicit about parent verses child.

ERDi, MESA: complexType name = "MaterialDefinitionPropertyType" / element name = "MaterialDefinitionProperty". Change to "MaterialDefinitionPropertyChild" to align with ISA-95 Part 2 identified role name. Current element is not explicit about parent verses child.

ERDi, MESA: complexType name = "MaterialLotPropertyType" / element name = "MaterialLotProperty". Change to "MaterialLotPropertyChild" to align with ISA-95 Part 2 identified role name. Current element is not explicit about parent verses child.

ERDi, MESA: complexType name = "MaterialDefinitionPropertyType", ADD element name = "MaterialClassPropertyID" type = "MaterialClassPropertyIDType". This aligns to updated ISA-95 Part 2.

ERDi, MESA: complexType name = "MaterialLotPropertyType", ADD element name = "MaterialDefinitionPropertyID" type = "MaterialDefinitionPropertyIDType". This aligns to updated ISA-95 Part 2.

racheliurui mentioned this issue

MaterialLotType: MaterialTestSpecificationID should be MaterialLotType: TestSpecificationID #14

Closed

racheliurui changed the title ~~MaterialDefinitionType: MaterialTestSpecificationID should be MaterialDefinitionType: TestSpecificationID~~ MaterialTestSpecificationID should be deprecated and replaced by TestSpecificationID

racheliurui added MESA and removed MISA labels

racheliurui changed the title ~~MaterialTestSpecificationID should be deprecated and replaced by TestSpecificationID~~ TestSpecificationID instead of xxxxTestSpecificationID should be included in testable object definition

racheliurui referenced this issue


          Update B2MML-equipment.xsd

2cc4e67

EquipmentInformationType: EquipmentCapabilityTestSpecification (line 165) should be deprecated and replaced by TestSpecification to align with updated Part 2, Operations Test Model.  This also aligns with the OpEquipmentRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition.

EquipmentType:  EquipmentCapabilityTestSpecificationID (line 193) should be deprecated and replaced by TestSpecificationID to align with updated Part 2, Operations Test Model.  This also aligns with the OpEquipmentRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition.

EquipmentPropertyType: Delete TestResult (line 211). In updated Part 2, Test Result was removed from the equipment property object and included in the Operations Test Model.  Test Result object has an association relationship to Equipment Actual and shall be added to the OpEquipmentActual schema in the Common Schema.  Also, Test Result object is now a 1st order object and should be added as a common schema with transactions.

EquipmentClassType:  EquipmentCapabilityTestSpecificationID (line 236) should be deprecated and replaced by TestSpecificationID to align with updated Part 2, Operations Test Model.  This also aligns with the OpEquipmentRequirementType: TestSpecificationID in the Common Schema for use in OperationsDefinition.

racheliurui added this to the Discussed & Commented milestone

Collaborator Author

racheliurui commented Aug 22, 2019

Agreed.
In the real case, test specification ID itself implies the ID can be used to find all the information regarding the specific test. With the element name try to declare where the sample comes from, will make things complicated.
A simplified tag would support using standard test specification model.

racheliurui mentioned this issue

Change xxxTestSpecification element to TestSpecification in all Resource.xsds, their xxxInformationType, and entity types to align with updated 950002 #10

Open

CharlieG021163 added a commit that referenced this issue


          Update B2MML-Personnel.xsd

8558fad

ERDI to do, MESA may not do. 
To align with updated Part 2, Operations Test Model. Related to #10 and #13. 
The following Impacted elements in PersonnelType should be changed replaced with TestSpecification and TestSpecificationID element:
Impacted Elements:
"PersonnelInformationType": "Qualification TestSpecification" TO "TestSpecification"
"PersonnelClassType": "QualificationTestSpecification" TO "TestSpecificationID"
"PersonType": "QualificationTestSpecification" TO "TestSpecificationID"

CharlieG021163 added a commit that referenced this issue


          Update B2MML-PhysicalAsset.xsd

12671eb

ERDI to do, MESA may not do. 
To align with updated Part 2, Operations Test Model. Related to #10 and #13. 
The following Impacted elements in PhysicalAssetType should be changed replaced with TestSpecification and TestSpecificationID element:
Impacted Elements:
"PhysicalAssetInformationType": "Qualification TestSpecification" TO "TestSpecification"
"PhysicalAssetClassType": "QualificationTestSpecification" TO "TestSpecificationID"
"PhysicalAssetType": "QualificationTestSpecification" TO "TestSpecificationID"

Collaborator Author

racheliurui commented Aug 26, 2019 •

edited

Loading

@CharlieG021163 may I suggest you please direct comment instead of editing initial comment of the issue unless the issue itself is opened by you.
That way, it's easier for me to read your feedback instead of checking the change of the initial comment.

racheliurui added the duplicate label

Collaborator Author

racheliurui commented Aug 26, 2019

As recommended by @CharlieG021163 , this change is duplicated with #10

The description of #10 will be updated to cover the change and this one will be labelled as duplicated and closed.

racheliurui closed this as completed

racheliurui mentioned this issue

Add TestSpecification element to MaterialSubLotType in Material.xsd to align with updated 950002 #15

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment