Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WorkflowSpecificationConnectionType to align with updated ISA-950004 #46

Open
racheliurui opened this issue Aug 28, 2019 · 4 comments
Open

Update WorkflowSpecificationConnectionType to align with updated ISA-950004 #46

racheliurui opened this issue Aug 28, 2019 · 4 comments
Assignees
@CharlieG021163 @gerardmoloneyetpartners
Labels
ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version
Milestone
AcceptedByMESA

Comments

@racheliurui
Copy link
Collaborator

racheliurui commented Aug 28, 2019 •
edited by CharlieG021163
Loading

Background
Explicitly Align B2MML with updated 950004 Workflow Specification Model, Clause 6.16.5 Workflow specification connection.

Supporting Document
ISA-950004 JWG5 CDV01 version (2019 12)
Clause 6.16.6 Workflow specification connection
Table 39 – Workflow specification connection relationship roles
Table 40 – Workflow specification connection attributes

Impacted Types and Solution
B2MML-WorkflowSpecification.xsd
complexType name = "WorkflowSpecificationConnectionType"

CHANGE: Align naming more closely with updated 950004 Workflow Specification Model to reduce confusion.

ADD: Align with updated 950004 Workflow Specification Model.

  • element name = "Dependency", type="DependencyType"/>
  • element name="DependencyFactor", type="ValueType" minOccurs="0"/>
racheliurui referenced this issue Aug 28, 2019
@CharlieG021163
Update B2MML-WorkflowSpecification.xsd
d112914 
ERDi, MESA:  complexType name = "WorkflowSpecificationInformationType">
CHANGE:  
- element name = "WorkflowSpecificationType"   type = "WorkflowSpecificationTypeType"  TO
     "WorkflowSpecificationNodeType"   type = "WorkflowSpecificationNodeTypeType" 
ADD:
- element name = "WorkflowSpecificationConnectionType"   type = "WorkflowSpecificationConnectionTypeType" minOccurs = "0" maxOccurs = "unbounded"/>

ERDi, MESA:  complexType name = "WorkflowSpecificationType">
CHANGE:
- element name = "Node" minOccurs = "0" maxOccurs = "unbounded"/> TO 
     "WorkflowSpecificationNode" minOccurs = "1" maxOccurs = "unbounded"/>
- element name = "Connection" TO "WorkflowSpecificationConnection"
- element name = "WorkflowSpecificationProperty" type = "WorkflowPropertyType" TO 
     "WorkflowSpecificationProperty" type = "WorkflowSpecificationPropertyType" 
- element name = "IncludesThePropertiesOf" TO "WorkflowSpecificationNodeParent"
ADD:
- element name = "DefinitionType", type = "DefinitionTypeType", minOccurs = "0"/>

ERDi, MESA:  complexType name = "WorkflowPropertyType", 
CHANGE: 
- complexType name = "WorkflowPropertyType" TO  "WorkflowSpecificationPropertyType"
- element name = "WorkflowProperty" TO "WorkflowSpecificationPropertyChild"
DELETE:
- element name = "EvaluatedPropertyReference"
- element name = "TestResult"

ERDI, MESA: DELETE complexType name = "WorkflowSpecificationTypeType",  This is an intermediate type which simply refers to WorkflowSpecificationNodeTypeType and WorkflowSpecificationConnectionTypeType.  It is simply not needed especially since these types are individually exchanged as first order objects as master data.  Also, the name, WorkflowSpecificationType, is confusing since it implies that there is a type of Workflow Specification which there is not in the updated ISA-95 Part 2. 

ERDi, MESA: complexType name = "WorkflowSpecificationNodeType">
ADD:
- element name = "Version", type = "VersionType"  minOccurs = "0"/>
- element name = "EffectiveFrom", type = "DateTimeType"  minOccurs = "0" />	    
- element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
CHANGE: 
- element name = "NodeType" type = "IdentifierType" /> TO 
     "WorkflowSpecificationNodeTypeID type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/>
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionNodeProperty", type = "WorkflowSpecificationNodePropertyType"   
- element name = "IncludesThePropertiesOf" TO "WorkflowSpecificationNodeParent"
ADD: 
- element name = "WorkMasterID", type = "IdentifierType" />, minOccurs = "0" maxOccurs = "unbounded"/>
- element name = "WorkDirectiveID",type ="IdentifierType" />, minOccurs = "0" maxOccurs = "unbounded"/>

ERDi, MESA:  complexType name = "WorkflowSpecificationConnectionType"> 
CHANGE:
- element name = "ConnectionType" type = "IdentifierType" /> TO 
     "WorkflowSpecificationConnectionTypeID type = "IdentifierType" minOccurs = "0" maxOccurs = "1"/>
- element name = "FromNodeID" TO "FromWSNodeID" 
- element name = "ToNodeID" TO "ToWSNodeID" 
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionConnectionProperty", type = "WorkflowSpecificationConnectionPropertyType"   
        
ERDi, MESA:  complexType name = "WorkflowSpecificationNodeTypeType"
ADD:
- element name = "Version", type = "VersionType"  minOccurs = "0"/>
- element name = "EffectiveFrom", type = "DateTimeType"  minOccurs = "0" />	    
- element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
CHANGE:
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionNodeTypeProperty", type = "WorkflowSpecificationNodeTypePropertyType"   

ERDi, MESA:  complexType name = "WorkflowSpecificationConnectionTypeType"
ADD:
- element name = "Version", type = "VersionType"  minOccurs = "0"/>
- element name = "EffectiveFrom", type = "DateTimeType"  minOccurs = "0" />	    
- element name = "EffectiveTo", type = "DateTimeType" minOccurs = "0" />
CHANGE:
- element name = "Property", type = "WorkflowSpecificationPropertyType" TO
      "WorkflowSpecifictionConnectionTypeProperty", type = "WorkflowSpecificationConnectionTypePropertyType"
@racheliurui racheliurui added ERDi Issues that need to be fixed in ERDi version MESA Issues that need to be fixed in MISA Version labels Aug 28, 2019
racheliurui referenced this issue Aug 28, 2019
@CharlieG021163
Update B2MML-WorkflowSpecification.xsd
d76f820 
ERDi, MESA: complexType name = "WorkflowSpecificationType"  to align with updated Part 2 Workflow Specification Model.
CHANGE:  element name = "WorkflowSpecificationParent", type = "IdentifierType"   minOccurs = "0" maxOccurs = "unbounded"/> 
     TO minOccurs = "0" maxOccurs = "1"/>

ERDi, MESA: complexType name = "WorkflowSpecificationNodeType" to align with updated Part 2 Workflow Specification Model.
CHANGE:  element name = "WorkflowSpecificationNodeParent", type = "IdentifierType"   minOccurs = "0" maxOccurs = "unbounded"/>
      TO minOccurs = "0" maxOccurs = "1"/>

ERDi, MESA:  xsd:complexType name = "WorkflowSpecificationConnectionType"  to align with updated Part 2 Workflow Specification Model.
ADD:  
- element name = "Dependency", type="DependencyType"/>
- element name="DependencyFactor", type="ValueType" minOccurs="0"/>

ERDi, MESA:  complexType name = "WorkflowSpecificationNodeTypeType" to align with updated Part 2 Workflow Specification Model.
ADD:  element name = "HierarchyScope", type = "HierarchyScopeType" minOccurs = "0"/> to align with updated Part 2 best practice to apply Hierarchy Scope to 1st class objects, this addition was added and comment submitted to ISA-95 for consideration.

ERDi, MESA:  complexType name = "WorkflowSpecificationConnectionTypeType" to align with updated Part 2 Workflow Specification Model.
ADD:  
- element name = "HierarchyScope", type = "HierarchyScopeType" minOccurs = "0"/> to align with updated Part 2 best practice to apply Hierarchy Scope to 1st class objects, this addition was added and comment submitted to ISA-95 for consideration.
- element name = "FromWSNodeMultiplicity", type = "DescriptionType"  minOccurs = "0"/>
- element name = "ToWSNodeMultiplicity", type = "DescriptionType"  minOccurs = "0"/>
- element name = "Dependency" type="DependencyType"/>
- element name = "DependencyFactor" type="ValueType"  minOccurs="0"/>

ERDi, MESA:  DELETE the "Common group for all elements" types and replace with specific types to align with updated Part 2 Test Specification model.  These common group schema make relationship elements between common group schema very confusing.  
ADD: 
- complexType name = "WorkflowSpecificationNodePropertyType".  
- complexType name = "WorkflowSpecificationNodeTypePropertyType".  
- complexType name = "WorkflowSpecificationConnectionPropertyType".
-  complexType name = "WorkflowSpecificationConnectionTypePropertyType".  

ERDi, MESA:  complexType name = "WorkflowSpecificationPropertyType".  This type as defined in updated Part 2 Workflow Specification model is specific to the Workflow Specification object.  B2MML attempts to use as a "common group" schema for all property objects.  This is very confusing and does not support relationship elements.  
DELETE: 
- element name = "PropertyType". This is a Part 2 attribute for resource properties with defined attributes of class type, instance type, and default type which does not represent the types workflow specification property objects.
CHANGE:  
- element name = "Property" TO "WorkflowSpecificationPropertyChild"
@CharlieG021163 CharlieG021163 changed the title update WorkflowSpecificationConnectionType to align with ISA-950004 Update WorkflowSpecificationConnectionType to align with ISA-950004 Sep 26, 2019
@racheliurui
Copy link
Collaborator Author

Agreed and assigned to @vitalJP and @gerardmoloneyetpartners

@CharlieG021163
Copy link
Collaborator

Original issue comment updated. Final

@CharlieG021163 CharlieG021163 added this to the Discussed & Commented milestone Oct 15, 2019
@CharlieG021163 CharlieG021163 removed this from the AgreedByWorkingGroup milestone Jan 15, 2020
@gerardmoloneyetpartners
Copy link
Collaborator

Agreed

@CharlieG021163 CharlieG021163 changed the title Update WorkflowSpecificationConnectionType to align with ISA-950004 Update WorkflowSpecificationConnectionType to align with updated ISA-950004 Jan 22, 2020
This was referenced Jan 29, 2020
Open
Open
@CharlieG021163 CharlieG021163 mentioned this issue Feb 10, 2020
Open
@Dennis-Brandl
Copy link

I agree with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlieG021163 CharlieG021163

@gerardmoloneyetpartners gerardmoloneyetpartners

Labels
ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version
Projects
None yet
Milestone
AcceptedByMESA
Development

No branches or pull requests
7 participants
@terryrankine @racheliurui @CharlieG021163 @Dennis-Brandl @vitalJP @factoryiq @gerardmoloneyetpartners