Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kona and Niro modules; remove Ioniq workaround #36

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Fix Kona and Niro modules; remove Ioniq workaround #36

merged 2 commits into from
Aug 4, 2019

Conversation

noradtux
Copy link
Contributor

@noradtux noradtux commented Aug 4, 2019

  • Fix an oversight on Kona and Niro
  • Remove a workaround for Ioniq; the problem was properly fixed by directly addressing the controll units

@noradtux noradtux requested a review from GPlay97 as a code owner August 4, 2019 07:40
@GPlay97 GPlay97 merged commit 44e8c1a into EVNotify:master Aug 4, 2019
DBestman pushed a commit to DBestman/EVNotiPi that referenced this pull request Mar 16, 2021
@noradtux @GPlay97
Fix Kona and Niro modules; remove Ioniq workaround (EVNotify#36)
64645f8 
* fix bad search and replace

* remove poll throttling for 2180, not needed anymore since direct addressing of controll units
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GPlay97 GPlay97 GPlay97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noradtux @GPlay97