Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #318

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Update dependencies #318

merged 5 commits into from
Aug 22, 2023

Conversation

hikinggrass
Copy link
Contributor

No description provided.

@hikinggrass hikinggrass requested a review from a-w50 August 18, 2023 06:37
a-w50
a-w50 requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@a-w50 a-w50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the one comment. Furthermore the tests don't run anymore:
Configured connection for requirement id(s) [ocpp] of probe_module:PyProbeModule not defined as requirement in manifest of module 'PyProbeModule'!

Otherwise 👍, rebase and squash, and refer to the latest everest-framework tag.

modules/SerialCommHub/tiny_modbus_rtu.cpp Outdated Show resolved Hide resolved
@hikinggrass
Copy link
Contributor Author

See the one comment. Furthermore the tests don't run anymore: Configured connection for requirement id(s) [ocpp] of probe_module:PyProbeModule not defined as requirement in manifest of module 'PyProbeModule'!

Otherwise 👍, rebase and squash, and refer to the latest everest-framework tag.

Which version of everest-testing do you have installed? I have 0.1.3 and the test run fine with it

@hikinggrass
Use fmt formatter from everest-framework
f3e7c2a 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Cast function code to integer
914f120 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
clang-format
52ccfdb 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use std::underlying_type_t in static cast
e9dc34a 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Bump libocpp version that includes the updated dependencies
2959c17 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@a-w50
Copy link
Contributor

a-w50 commented Aug 22, 2023

See the one comment. Furthermore the tests don't run anymore: Configured connection for requirement id(s) [ocpp] of probe_module:PyProbeModule not defined as requirement in manifest of module 'PyProbeModule'!
Otherwise 👍, rebase and squash, and refer to the latest everest-framework tag.

Which version of everest-testing do you have installed? I have 0.1.3 and the test run fine with it

We'll, now its working ... ❓

a-w50
a-w50 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@a-w50 a-w50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine now, don't forget to squash

@hikinggrass hikinggrass merged commit b21f32c into main Aug 22, 2023
1 of 3 checks passed
@hikinggrass hikinggrass deleted the kh-update-dependencies branch August 22, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-w50 a-w50 a-w50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hikinggrass @a-w50