bug: correct precision of meter_start #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meter start value (the energy in Wh that a powermeter reports at the beginning of a transaction) is internally represented in the transaction class (for ocpp 1.6) as a `StampedEnergyWh`. `StampedEnergyWh` records this value as a `double` and hence its constructor should also accept the energy as a `double` (it used to take an `int32`). Furthermore, the set of `on_transaction_started` for ocpp 1.6 also only accepted `int32` values. These have been changed to `double` too, as there should be no reason to truncate them before. Furthermore the `meter_start` argument is passed by value now. Passing by reference for these *simple* and small types is just not necessary. Note: the same could be done for the `on_transaction_stopped` functions. Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
Signed-off-by: aw <aw@pionix.de>
Pietfried
approved these changes
May 30, 2024
couryrr-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Jun 12, 2024
* bug: correct precision of meter_start The meter start value (the energy in Wh that a powermeter reports at the beginning of a transaction) is internally represented in the transaction class (for ocpp 1.6) as a `StampedEnergyWh`. `StampedEnergyWh` records this value as a `double` and hence its constructor should also accept the energy as a `double` (it used to take an `int32`). Furthermore, the set of `on_transaction_started` for ocpp 1.6 also only accepted `int32` values. These have been changed to `double` too, as there should be no reason to truncate them before. Furthermore the `meter_start` argument is passed by value now. Passing by reference for these *simple* and small types is just not necessary. Note: the same could be done for the `on_transaction_stopped` functions. --------- Signed-off-by: aw <aw@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meter start value (the energy in Wh that a powermeter reports at the beginning of a transaction) is internally represented in the transaction class (for ocpp 1.6) as a
StampedEnergyWh.StampedEnergyWhrecords this value as adoubleand hence its constructor should also accept the energy as adouble(it used to take anint32).Furthermore, the set of
on_transaction_startedfor ocpp 1.6 also only acceptedint32values. These have been changed todoubletoo, as there should be no reason to truncate them before. Furthermore themeter_startargument is passed by value now. Passing by reference for these simple and small types is just not necessary.Note: the same could be done for the
on_transaction_stoppedfunctions.Describe your changes
Issue ticket number and link
Checklist before requesting a review