general: Add basic unit tests and CI

[christopher-davis-afs]

Adds basic unit tests and CI. The tests are a placeholder for now, this PR just provides the infrastructure for unit tests.

CC: @shankari @AssemblyJohn @Dominik-K

[shankari]

This is also not running the newly added checks. And it is not even running the codecov action.
I only see the DCO check here...

[shankari]

@christopher-davis-afs the good news is that the tests are running. The bad news is that a file that you modified is failing the static code analysis. I don't see think that the particular line that is being flagged has changed, but it would be worthwhile to ensure that the check passes.

Also, would it be possible to include the incremental changes as separate commits? I had some feedback, and you have addresse it, but I don't see a single commit for that. So I have to look at all the files and wonder what else might have changed. Or basically do a full re-review.

[christopher-davis-afs]

GitHub has a button for comparing changes when someone makes a push. See "Compare" here.

My action is still not running, and the code broken in the static code analysis check is something that I did not change at all.

[christopher-davis-afs]

Actually, that file was changed by clang-format, but otherwise this issue exists on main.

[christopher-davis-afs]

Fixed that issue

[shankari]

@christopher-davis-afs

GitHub has a button for comparing changes when someone makes a push. See "Compare" here.

That's interesting! I had not noticed that before. Is there a reason you prefer this over just adding a new commit to fix the comment? I generally prefer the new commit because then the commit history reflects the comments that were addressed.

Fixed that issue

Great! I am going to approve this now, but it looks like you resolved it primarily by reverting the clang changes to the file. Doesn't this mean that the clang check will fail when workflows are enabled? I don't see a recent passing run on the US-JOET repo (https://github.com/US-JOET/libslac/actions

[andistorm]

When the pull request is ready for merging, please mark me as a reviewer.

[christopher-davis-afs]

I believe this (and my other PRs) are ready, unless you have additional review comments?

[andistorm]

Looks good to me in general, with a few minor comments.

Could you provide a link to a successful run of this workflow in your fork?

[andistorm]

Cool 👍