Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some ignored tests #12

Merged
merged 2 commits into from
May 21, 2018
Merged

Enable some ignored tests #12

merged 2 commits into from
May 21, 2018

Conversation

siy
Copy link
Contributor

@siy siy commented May 21, 2018

Signed-off-by: Sergiy Yevtushenko sergiy.yevtushenko@pragmaticcoders.com

Signed-off-by: Sergiy Yevtushenko <sergiy.yevtushenko@pragmaticcoders.com>
@siy siy requested review from jksf and jaupe May 21, 2018 10:38
@@ -186,7 +186,7 @@ func createSpendingTx(sigScript, pkScript []byte) *wire.MsgTx {
// as expected.
//TODO: enable test and make it working
func TestScriptInvalidTests(t *testing.T) {
//For some reason this test hangs IDE and PC
//Depends on enternal files with binary data (encoded)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: external

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please leave space after comment symbol like

//Depends
to
// Depends

Signed-off-by: Sergiy Yevtushenko <sergiy.yevtushenko@pragmaticcoders.com>
@siy
Copy link
Contributor Author

siy commented May 21, 2018

Fix applied

Copy link
Contributor

@jksf jksf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jksf jksf merged commit f99f17e into master May 21, 2018
@jksf jksf deleted the fix/Try_enable_disabled_tests branch May 21, 2018 13:44
pingwindyktator added a commit that referenced this pull request Jul 24, 2018
pingwindyktator added a commit that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants