Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEX-143 Change inflation parameters #14

Merged
merged 1 commit into from
May 23, 2018

Conversation

harzo
Copy link
Contributor

@harzo harzo commented May 23, 2018

@harzo harzo requested a review from jksf May 23, 2018 12:00
@jksf
Copy link
Contributor

jksf commented May 23, 2018

@harzo Are you sure that inflation parameters are correct?
I see block rewards of 26.6 EXCC when I start the mainnet locally.

2018-05-23 14:35:55.281 [INF] MINR: Block submitted via CPU miner accepted (hash 3713bd2a58108f895998a7a97eee56ce6b48d9ad4f3583a20e5e5707cef9d5c1, height 1, amount 10719596.14567118 EXCC)
2018-05-23 14:40:57.020 [INF] MINR: Block submitted via CPU miner accepted (hash 1bae724ccc07d4137a9631ab05720bef6e3d404d54147f4412b21d823af45901, height 2, amount 26.6 EXCC)
2018-05-23 14:45:58.610 [INF] MINR: Block submitted via CPU miner accepted (hash 2f77a3b8378238c1ed3ae6c9021b5393e7482bad03ef2439ecdb6b67c04e7bdb, height 3, amount 26.6 EXCC)
2018-05-23 14:50:59.964 [INF] MINR: Block submitted via CPU miner accepted (hash 527e1eb584c58d07bbecc18b0abf9a19682d9e5a11ffb9bd9c2dda3003eec9e3, height 4, amount 26.6 EXCC)
2018-05-23 14:56:01.339 [INF] MINR: Block submitted via CPU miner accepted (hash 41715075dbb494ca1f911e7012bd0df1f44946a51225fb0d3ec437d1ae70ede4, height 5, amount 26.6 EXCC)

@harzo
Copy link
Contributor Author

harzo commented May 23, 2018

@jksf
Well this is because it shows only 7/10 of whole reward (miner share) the rest is for stakers:
38 * 0.7 = 26.6

But i'm not sure if this is right behavior. If there is no stakers, whole reward should go to the miners.

Copy link
Contributor

@jksf jksf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you are right. That looks good. I wouldn't change the default behavior as it may create a bad incentive for the miners.

@jksf jksf merged commit bbdaf90 into task/DEX-161_test_mainnet May 23, 2018
@jksf jksf deleted the task/DEX-143_change_inflation_rules branch May 23, 2018 13:26
pingwindyktator added a commit that referenced this pull request Jul 24, 2018
pingwindyktator added a commit that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants