-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console error ouput #36
Comments
@BBE78 I totally agree with your statements and your recommendation. Having said that, I don't think I will have time to implement that. |
Hi @danielpeintner, That's the plan, coming soon... |
Hi @danielpeintner , 3 PR EXIficient/exificient-core#11, EXIficient/exificient-grammars#22, #37 are available to fix this issue |
Thanks for your work and your contribution! I added some minor comments to all the PRs .. EDIT: BTW, I think with a logging framework in place we could also add log statements to SAXDecoder.java and many other classes that are at the moment commented out code (with lower LOG level). Anyhow, this can (and maybe should) be done in follow-up PRs. These initial PRs should focus on the error log statements as you suggested. |
Hi, I will take them into account in next days... |
Hi @BBE78 Thanks for your work. All your PRs should be merged by now 👍 |
Good job 😉 |
Issue can be closed, right? |
I think so |
Some piece of code is using
System.err.println()
to trace error messages.This is not recommended, and the use of a logger framework is better
The text was updated successfully, but these errors were encountered: