Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error ouput #36

Closed
BBE78 opened this issue Mar 17, 2023 · 9 comments
Closed

Console error ouput #36

BBE78 opened this issue Mar 17, 2023 · 9 comments

Comments

@BBE78
Copy link
Contributor

BBE78 commented Mar 17, 2023

Some piece of code is using System.err.println() to trace error messages.
This is not recommended, and the use of a logger framework is better

@danielpeintner
Copy link
Member

@BBE78 I totally agree with your statements and your recommendation.

Having said that, I don't think I will have time to implement that.
If you plan to work on a PR that is highly accepted and I will try to find time reviewing it..

@BBE78
Copy link
Contributor Author

BBE78 commented Mar 20, 2023

Hi @danielpeintner, That's the plan, coming soon...

@BBE78
Copy link
Contributor Author

BBE78 commented Mar 23, 2023

Hi @danielpeintner , 3 PR EXIficient/exificient-core#11, EXIficient/exificient-grammars#22, #37 are available to fix this issue
Happy review!

@danielpeintner
Copy link
Member

danielpeintner commented Mar 24, 2023

Thanks for your work and your contribution!

I added some minor comments to all the PRs ..

EDIT: BTW, I think with a logging framework in place we could also add log statements to SAXDecoder.java and many other classes that are at the moment commented out code (with lower LOG level). Anyhow, this can (and maybe should) be done in follow-up PRs. These initial PRs should focus on the error log statements as you suggested.

@BBE78
Copy link
Contributor Author

BBE78 commented Mar 25, 2023

Hi, I will take them into account in next days...

danielpeintner added a commit that referenced this issue Mar 31, 2023
@danielpeintner
Copy link
Member

Hi @BBE78

Thanks for your work. All your PRs should be merged by now 👍

@BBE78
Copy link
Contributor Author

BBE78 commented Apr 3, 2023

Good job 😉

@danielpeintner
Copy link
Member

Issue can be closed, right?

@BBE78
Copy link
Contributor Author

BBE78 commented May 12, 2024

Issue can be closed, right?

I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants