Fix app icon on linux when installing from generated jpackage file #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raujonas
added
bug
farion
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: CorreoMQTT has no icon in the dock on Ubuntu 20.04 with gnome shell 3.36.4 (I think this might has always been an issue on linux?). Also if you create a shortcut for correo on the dock, the application is started as a new window because the wm_class is not matching.
Also there is not the correct application name displayed in the status bar:
Solution:
All windows are grouped correctly under the same icon even if it is pinned as a shortcut on the dock.
Changes tested for deb, rpm and msi packages.
@farion Could you please update the commands in the wiki to match the new ones from .travis/build.bash? I am not allowed to do this I think.