Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements demo-ui #1410

Merged
merged 17 commits into from
May 31, 2023
Merged

implements demo-ui #1410

merged 17 commits into from
May 31, 2023

Conversation

LijuJoseJJ
Copy link
Contributor

@LijuJoseJJ LijuJoseJJ commented Mar 24, 2023

What does this implement/fix? Explain your changes.

This PR create a small react app called demo-ui, intension is demo-ui will be used to test contracts deployed in mumbai testnet.
for now: it has been test against local ganache instead of mumbai testnet deployments
fixes #1385

pending work:-

  • this PR remove use of find-unused-exports to make demo-ui npm run lint work. Solution is to find better module than find-unused-exports to make it work for both node.js and react code.
  • code refactor : Although demo-ui app is small and working, but need more react smart code compare what is in this PR.
  • better CSS

Does this close any currently open issues?

What commands can I run to test the change?

To run demo-ui:-

  1. start nightfall
  2. cd demo-ui
  3. npm ci
  4. npm start

Any other comments?

@LijuJoseJJ LijuJoseJJ requested a review from Westlad March 24, 2023 08:08
Copy link
Contributor

@Westlad Westlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, for merge. Details are being added to the Gitbook.

@Westlad Westlad added the One more approval needed One reviewer has approved this PR but another is needed label May 18, 2023
@Westlad Westlad merged commit b53f171 into master May 31, 2023
@Westlad Westlad deleted the liju.jose/implement-demo-ui branch May 31, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
One more approval needed One reviewer has approved this PR but another is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightweight demo UI
3 participants