Skip to content
This repository has been archived by the owner on Oct 25, 2018. It is now read-only.

Gui contacts and key generation #90

Merged
merged 18 commits into from
Aug 17, 2018
Merged

Gui contacts and key generation #90

merged 18 commits into from
Aug 17, 2018

Conversation

diveshuttam
Copy link

@diveshuttam diveshuttam commented Aug 17, 2018 •
edited
Loading

Closes #87, Closes #86 , Closes #80
This pr implements the most of the contact commands as well as key commands for initialization.

I have added possible improvements as TODO's, they are mostly something I struggled with either conceptually or because of yad.

@dashohoxha have a look whenever you are free.
TODO's required some thinking and discussion so I would probably solve them in another pr.

Note:

  • for contact search it was difficult to implement the gui. I have launched a gnome-terminal instance instead with the gui command. While testing on the container, you will require to download the same. I am not adding it in docker file as it is a temporary solution. Will improve in another pr

Since I was taking many features in consideration, I have used commits with proper messages for each unit. It might help you in review.

@diveshuttam
added fetch
c47d134
@diveshuttam
added key restore
64bd99a
@diveshuttam
Add recover
a4866dd
@diveshuttam
Add dummy files and organize functions
e9663d0
@diveshuttam
minor correction in export logic
08ad0e3
@diveshuttam
use contact_id instead of
c238363
@diveshuttam
add contact export
f67e534
@diveshuttam
add contact delete
d6102a5 
helps with #80
@diveshuttam
add gui contact certify
30ed96b 
helps with #80
@diveshuttam
minor correction in markup
848552c
@diveshuttam
added contact trust
6a6f9fe 
helps with #80
@diveshuttam
add error messages for key command
a8ffa4d 
helps with #87
@diveshuttam
add info message for keys
f423b27
@diveshuttam
s/contact/contacts
05ef3b8
@diveshuttam
Add contact fetch (from dir)
3a01cf1 
modify existing cmd_contact_fetch to return correct error status
helps with #86
@diveshuttam
add contact import
ccd5bbc 
helps with #86
@diveshuttam
Added contact receive
9a9b45a 
helps with #86
@diveshuttam
Add a basic working search
5cd4621 
currently launcing a terminal instance for it to work.
We may need to use python version for this to work
helps with #86
@diveshuttam diveshuttam self-assigned this Aug 17, 2018
@diveshuttam diveshuttam changed the title Gui contacts Gui contacts and key generation Aug 17, 2018
@dashohoxha
Copy link
Member

👍 I am going to have a look at it soon.

If you need to merge it (for example if it prevents you from working further) you can go on. I can still review it and make any necessary fixes after it has been merged.

@diveshuttam diveshuttam merged commit 0cd2177 into gnupg-2.2-gui Aug 17, 2018
@diveshuttam diveshuttam mentioned this pull request Aug 17, 2018
Open
6 tasks
@diveshuttam diveshuttam deleted the gui_contacts branch August 17, 2018 21:13
@diveshuttam
Copy link
Author

Cool!
Also you might find it easier to test this after setting and key commands are ready.
I am currently working on them will create a pr by tomorrow. Maybe we can address this after I implement them also and save some time.

@dashohoxha
Copy link
Member

Thanks, I appreciate it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashohoxha dashohoxha Awaiting requested review from dashohoxha

Assignees

@diveshuttam diveshuttam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diveshuttam @dashohoxha