Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Refund function in insurance service #329

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Add Refund function in insurance service #329

merged 7 commits into from
Apr 8, 2024

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented Mar 28, 2024 •
edited
Loading

Description

Add Refund function in insurance service for insurance cancellation endpoint
CI build was failing due to another conftest.py in the submodule, fixed this by adding pytest.ini

Testing

Add unit test

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 force-pushed the insurance_cancellation_function branch 2 times, most recently from 1958c4c to d1f221b Compare March 28, 2024 21:35
@jchen293 jchen293 marked this pull request as ready for review March 29, 2024 18:24
@jchen293 jchen293 requested a review from a team March 29, 2024 18:24
nwithan8
nwithan8 previously approved these changes Mar 29, 2024
View reviewed changes
pytest.ini Outdated Show resolved Hide resolved
Justintime50
Justintime50 previously approved these changes Mar 29, 2024
View reviewed changes
easypost/services/insurance_service.py Outdated Show resolved Hide resolved
@jchen293 jchen293 marked this pull request as draft March 29, 2024 19:23
@jchen293 jchen293 dismissed stale reviews from Justintime50 and nwithan8 via 5a8cb90 April 4, 2024 16:41
@jchen293 jchen293 force-pushed the insurance_cancellation_function branch from 75ba0eb to 5a8cb90 Compare April 4, 2024 16:41
@jchen293 jchen293 marked this pull request as ready for review April 4, 2024 16:42
Justintime50
Justintime50 previously approved these changes Apr 4, 2024
View reviewed changes
nwithan8
nwithan8 previously approved these changes Apr 4, 2024
View reviewed changes
@jchen293 jchen293 dismissed stale reviews from nwithan8 and Justintime50 via 82cd86b April 8, 2024 18:01
@jchen293 jchen293 merged commit aebdf30 into master Apr 8, 2024
8 checks passed
@jchen293 jchen293 deleted the insurance_cancellation_function branch April 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@Justintime50 Justintime50 Justintime50 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50