-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
197 move from poetry to hatchling python packaging tools #202
197 move from poetry to hatchling python packaging tools #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the two imports in __init__.py
are required for the rest of EasyScience to function.
Borg
is pretty transparent, but the reason to import numpy
from easyCore is a bit more murky. I think the idea was that at some point, modifications to numpy were expected, hence we wanted our version of numpy used.
However, none of those extensions have yet been implemented and we seem to be pretty negligent, using both from easyCore import np
and import numpy as np
throughout the code base.
This begs for standardization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now!
pyproject.yml
easyCore
np
are longer fromeasyCore
but instead:import numpy as np
test_core
where easyCore.inf is replaced by np.inf