Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197 move from poetry to hatchling python packaging tools #202

Merged

Conversation

andped10
Copy link
Collaborator

@andped10 andped10 commented Mar 13, 2024

pyproject.yml

  • Changed hatchling
  • Added ruff specifications

easyCore

  • imports of np are longer from easyCore but instead: import numpy as np
    • tests/unit_tests/utils/io_tests/test_core.py
    • the above mentioned change is apparent in the test_core where easyCore.inf is replaced by np.inf
  • different changes to satisfy ruff
  • no changes to logic

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@andped10 andped10 added the chore label Mar 13, 2024
@andped10 andped10 requested a review from rozyczko March 13, 2024 10:05
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the two imports in __init__.py are required for the rest of EasyScience to function.
Borg is pretty transparent, but the reason to import numpy from easyCore is a bit more murky. I think the idea was that at some point, modifications to numpy were expected, hence we wanted our version of numpy used.
However, none of those extensions have yet been implemented and we seem to be pretty negligent, using both from easyCore import np and import numpy as np throughout the code base.
This begs for standardization.

easyCore/__init__.py Show resolved Hide resolved
easyCore/__init__.py Show resolved Hide resolved
@andped10 andped10 requested a review from rozyczko March 13, 2024 13:09
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now!

@andped10 andped10 merged commit 47b3ce5 into develop Mar 14, 2024
28 checks passed
@andped10 andped10 deleted the 197-move-from-poetry-to-hatchling-python-packaging-tools branch March 14, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants