Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

204 make release 040 #205

Merged
merged 4 commits into from
Mar 14, 2024
Merged

204 make release 040 #205

merged 4 commits into from
Mar 14, 2024

Conversation

andped10
Copy link
Collaborator

Copied workflows from Reflectometry

Changed how the module version is determined

@andped10 andped10 added the chore label Mar 14, 2024
@andped10 andped10 requested a review from rozyczko March 14, 2024 12:49
rozyczko
rozyczko approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.
Please consider updating one of the actions used (upload-artifact)

.github/workflows/python-package.yml Show resolved Hide resolved
.github/workflows/python-package.yml Outdated Show resolved Hide resolved
.github/workflows/python-publish.yml Outdated Show resolved Hide resolved
@andped10 andped10 merged commit 0a2e684 into develop Mar 14, 2024
28 checks passed
@andped10 andped10 deleted the 204-make-release-040 branch March 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@rozyczko rozyczko rozyczko approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andped10 @rozyczko