Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "DataFrames" to "1.0" #38

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DataFrames package from 0.21,0.22 to 0.21,0.22, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@richardreeve richardreeve force-pushed the compathelper/new_version/2021-04-22-04-03-12-249-3903189697 branch from ad6e847 to a274412 Compare April 22, 2021 04:03
@coveralls
Copy link

coveralls commented Apr 22, 2021

Pull Request Test Coverage Report for Build 772912636

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.0%) to 86.575%

Totals Coverage Status
Change from base Build 756304336: 6.0%
Covered Lines: 503
Relevant Lines: 581

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #38 (a274412) into dev (756a4db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #38   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          15       15           
  Lines         623      623           
=======================================
  Hits          503      503           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 756a4db...a274412. Read the comment docs.

@richardreeve richardreeve merged commit c1b9a1e into dev Apr 22, 2021
@richardreeve richardreeve deleted the compathelper/new_version/2021-04-22-04-03-12-249-3903189697 branch April 22, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants