-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#94 clean up changed or deleted observations #106
Merged
amazing-will
merged 12 commits into
main
from
#94-Clean-up-changed-or-deleted-observations
Aug 1, 2024
Merged
#94 clean up changed or deleted observations #106
amazing-will
merged 12 commits into
main
from
#94-Clean-up-changed-or-deleted-observations
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worflow to inspect all CAMS entries synchronised previously and to compare with iNat. Any additional CAMS features are removed from CAMS as the original iNat observation has changed species or has been deleted.
…lean-up-changed-or-deleted-observations
nigelcharman
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It doesn't look like cams_cleanup_writer is being called yet. Can we remove that class for now? I'll check with Keith what he'd like us to do in CAMS with entries that have been deleted from iNat.
no it's not being called. When we know the comparison is working it will do
the deletions... so it's a placeholder.
…On Thu, 1 Aug 2024 at 14:50, Nigel Charman ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good. It doesn't look like cams_cleanup_writer is being called yet.
Can we remove that class for now? I'll check with Keith what he'd like us
to do in CAMS with entries that have been deleted from iNat.
—
Reply to this email directly, view it on GitHub
<#106 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4BJEKTLLQS65CGHC4EGMMDZPGO6XAVCNFSM6AAAAABLZQGCMGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJRGQ3TEMJXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.