Single module Natural to reduce maintenance burden #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the measurements. The overall performance and size improvements are not big enough to really justify the refactor into a single module. And more importantly, I've tested single-module version with the demo app and our other apps and it doesn't solve the pipe injection problem that we currently encounter with the File component. |
|
True, it does not solve the pipe injection, which is extremely surprising 😲 ... |
|
Closing because #72 (comment) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new branch
single-moduleis also available in the mentioned projects for local testing.OKpilot
Before
After
Epicerio
Before
After
Ecolock
Before
After
Natural
Before
After
Conclusion
All applications grew, by ~4-100kb. So 100.1% - 103.0% of original size.
Compilation time is a bit shorter for bigger application such as OKpilot and Epicerio. But small application such as Ecolock suffer a huge increase of compilation time. I assume it spend a lot of time to treeshake things that are never needed at all. So overall it's 84.9% - 162% of original time.
Less relevant but Natural itself is 96.6% of original size and 75.7% of compile time.
It is not as clear as I expected. But because bundle size is probably the most critical measure of all, and because we already have multiples modules, I'd tend to not change anything.
WDTY ?