Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ne pas passer undefined en clé de version à l'export #857

Closed
davidbgk opened this issue Apr 24, 2023 · 2 comments · Fixed by #861
Closed

Ne pas passer undefined en clé de version à l'export #857

davidbgk opened this issue Apr 24, 2023 · 2 comments · Fixed by #861

Comments

@davidbgk
Copy link
Collaborator

davidbgk commented Apr 24, 2023 •
edited
Loading

Ici https://github.com/EcrituresNumeriques/stylo/blob/master/front/src/components/Export.jsx#L28

On a &version=${articleVersionId} qui devient &version=undefined dans certains cas, ça serait mieux que ça devienne &version= (ça reste un paramètre requis)
@ggrossetie
Copy link
Collaborator

La version d'un article est optionnelle quand on est sur une version de travail

(ça reste un paramètre requis)

C'est à dire qu'il faut que version soit présent mais peut être vide ?

@davidbgk
Copy link
Collaborator Author

davidbgk commented May 3, 2023

Oui c'est ça 👍

ggrossetie added a commit to ggrossetie/stylo that referenced this issue May 3, 2023
@ggrossetie
resolves EcrituresNumeriques#857 renseigne vide quand il n'y a pas de…
c46019b 
… versoin
@ggrossetie ggrossetie mentioned this issue May 3, 2023
Merged
ggrossetie added a commit that referenced this issue May 3, 2023
@ggrossetie
resolves #857 renseigne vide quand il n'y a pas de version (#861)
8496971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #857 renseigne vide quand il n'y a pas de version ggrossetie/stylo
2 participants
@davidbgk @ggrossetie