profile delete feature #8437

webAbhi · 2023-08-01T14:03:37Z

Fixes Issue

fixes #8260

Changes proposed

Added delete feature on update profile page.
Update profile api can now update isEnabled flag.

Check List (Check all the applicable boxes)

My code follows the code style of this project.
My change requires changes to the documentation.
I have updated the documentation accordingly.
All new and existing tests passed.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

pages/account/manage/profile.js

ThomasCode92

Looks good to me.
I made one small comment, but that's just my personal preference.

eddiejaoude

Looks good 👍 but after having a play, I think the workflow of enabling the profile needs to be added because now my profile is empty but my links are populated which is confusing

I think we need this steps

new page with "profile deactivated" message and a button to enable profile
all manage pages should redirect to new deactivated profile page to avoid confusion

webAbhi · 2023-08-03T15:34:07Z

Are we expecting a redirection from statistics tab as well or user can see statistics page with disable profile ?

eddiejaoude · 2023-08-03T15:37:34Z

Are we expecting a redirection from statistics tab as well or user can see statistics page with disable profile ?

Redirect also please, they should not be able to do anything until they re-enable their account

webAbhi · 2023-08-04T06:19:41Z

@eddiejaoude i have made all the changes, let me know if we can make any more improvements in this feature.

azhechkova · 2023-08-07T14:04:52Z

Looks good to me

eddiejaoude · 2023-08-10T09:51:08Z

pages/account/manage/events.js

+  }
+
+  //reroute to profile deactivated page if profile is disabled
+  if(profile && profile.hasOwnProperty("isEnabled") && !profile["isEnabled"]) {


!profile["isEnabled"] is not the coding style we generally use

I think this could be simplified to

Suggested change

if(profile && profile.hasOwnProperty("isEnabled") && !profile["isEnabled"]) {

if(profile && !profile.isEnabled) {

eddiejaoude · 2023-08-10T09:52:07Z

pages/account/manage/profile.js

+      headers: {
+        "Content-Type": "application/json",
+      },
+      body: JSON.stringify({ name, bio, tags, layout, isEnabled: false}),


if doing a delete, I don't think all the other data fields are required

Using all the data fields could this be simplified by re-using the handleSubmit function?

if doing a delete, I don't think all the other data fields are required

https://github.com/EddieHubCommunity/LinkFree/blob/32fb2bd52bc71791a169458eaa96a2b67d780b91/pages/api/account/manage/profile.js#L60
while creating the updateProfile object , we are completely relying on req.body data. we can also perform findOne call using _id in API but it doesn't felt appropriate to add a new DB call for this. so i thought it's a good idea to send all data.

Using all the data fields could this be simplified by re-using the handleSubmit function?

Are you looking for a approach similar to this ?

const deleteProfile = async() => { handleSubmit(false); // false is isEnabled flag value return Router.push(`${BASE_URL}/account/profile-deactivated`); }

This approach for some reason is adding a reload to profile page whenever handleSubmit is called.

I will have a look

eddiejaoude

Thank you 👍

I left some inline comments
When visiting the profile after the delete, it is still reachable - the profile page (api) needs to check the profile is enabled, and if it is false to return a 404
Please can you resolve the conflicts

webAbhi · 2023-08-18T14:31:04Z

Thank you 👍

I left some inline comments

When visiting the profile after the delete, it is still reachable - the profile page (api) needs to check the profile is enabled, and if it is false to return a 404

Please can you resolve the conflicts

Replied in comments.
Done
Done

Let me know if you still feel anymore changes can be done here, Thanks !!

eddiejaoude · 2023-08-25T09:08:03Z

Thank you for making the changes, I will take a look 👍

azhechkova

I've left a comment about the broken user creation

azhechkova · 2023-08-28T09:53:03Z

pages/account/manage/profile.js

+  //reroute to profile deactivated page if profile is disabled
+  if(profile && !profile.isEnabled) {
+    return {
+      redirect: {
+        destination: "/account/profile-deactivated",
+        permanent: false,
+      }
+    }
+  }
+


I can't create a new profile since new user is not enabled by default. Additionally, there is a check for if (profile && !profile.isEnabled) in all account pages, so I can't setup a profile.

Hey how can i test the user creation flow? Generally i connect my account locally by the help of access token generated from github.

Hi, sorry for the long reply. I use Github OAUth keys for local development. so, i can create a profile, log in and modify it using my github info. here's more info about it https://www.biodrop.io/docs/environments/environment-variables

we are specifying isEnabled flag default value as true in Profile schema, so ideally it should inject default value for a new user. not sure why is this going wrong. i am kind of stuck at this issue, can you please guide me anyway possible ?

@webAbhi come and chat to us in EddieHub Discord, we can help better there

SaraJaoude · 2023-09-25T18:48:35Z

Due to lack of activity I am going to close this PR.

SaraJaoude added the issue linked Pull Request has issue linked label Aug 2, 2023

ThomasCode92 reviewed Aug 2, 2023

View reviewed changes

pages/account/manage/profile.js Show resolved Hide resolved

ThomasCode92 approved these changes Aug 2, 2023

View reviewed changes

eddiejaoude suggested changes Aug 2, 2023

View reviewed changes

eddiejaoude reviewed Aug 10, 2023

View reviewed changes

eddiejaoude suggested changes Aug 10, 2023

View reviewed changes

abhijeet-render and others added 3 commits August 18, 2023 19:47

profile delete feature

c67c221

added redirection on all manage links

2c5c097

added not found check in profile page

f804068

webAbhi force-pushed the profile-delete-feature branch from dc1c066 to f804068 Compare August 18, 2023 14:19

azhechkova suggested changes Aug 28, 2023

View reviewed changes

SaraJaoude closed this Sep 25, 2023

SaraJaoude mentioned this pull request Sep 25, 2023

[FEATURE] Profile Delete feature #8260

Closed

webAbhi deleted the profile-delete-feature branch October 27, 2023 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

profile delete feature #8437

profile delete feature #8437

webAbhi commented Aug 1, 2023 •

edited by eddiejaoude

Loading

ThomasCode92 left a comment

eddiejaoude left a comment

webAbhi commented Aug 3, 2023

eddiejaoude commented Aug 3, 2023

webAbhi commented Aug 4, 2023

azhechkova commented Aug 7, 2023

eddiejaoude Aug 10, 2023

eddiejaoude Aug 10, 2023

eddiejaoude Aug 10, 2023

webAbhi Aug 10, 2023 •

edited

Loading

webAbhi Aug 10, 2023

eddiejaoude Aug 26, 2023

eddiejaoude left a comment •

edited

Loading

webAbhi commented Aug 18, 2023

eddiejaoude commented Aug 25, 2023

azhechkova left a comment

azhechkova Aug 28, 2023

webAbhi Sep 6, 2023

azhechkova Sep 8, 2023 •

edited

Loading

webAbhi Sep 12, 2023

eddiejaoude Sep 13, 2023

SaraJaoude commented Sep 25, 2023

	if(profile && profile.hasOwnProperty("isEnabled") && !profile["isEnabled"]) {
	if(profile && !profile.isEnabled) {

profile delete feature #8437

profile delete feature #8437

Conversation

webAbhi commented Aug 1, 2023 • edited by eddiejaoude Loading

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

ThomasCode92 left a comment

Choose a reason for hiding this comment

eddiejaoude left a comment

Choose a reason for hiding this comment

webAbhi commented Aug 3, 2023

eddiejaoude commented Aug 3, 2023

webAbhi commented Aug 4, 2023

azhechkova commented Aug 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webAbhi Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eddiejaoude left a comment • edited Loading

Choose a reason for hiding this comment

webAbhi commented Aug 18, 2023

eddiejaoude commented Aug 25, 2023

azhechkova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azhechkova Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SaraJaoude commented Sep 25, 2023

webAbhi commented Aug 1, 2023 •

edited by eddiejaoude

Loading

webAbhi Aug 10, 2023 •

edited

Loading

eddiejaoude left a comment •

edited

Loading

azhechkova Sep 8, 2023 •

edited

Loading