[FEATURE] Profile Delete feature

[amitthecoder]

Description

Hello LinkFree Contributors, Today I am creating a LnkeFree account For some reason I want to delete my account but delete option is not available. I removed github authorizations but my profile shows on LinkFree.

Screenshots

No response

Additional information

No response

[github-actions]

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/LinkFree/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

[github-actions]

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

[eddiejaoude]

This was coming soon, but we can make it a higher priority.

Can I ask why you want to delete your account, not sure what you mean by "some reason"?

[abhijeetrayy]

I can do that but need your views on it to procced or not (people/geeks)

[amitthecoder]

Yes Proceed

…

On Wed, 19 Jul 2023 at 14:29, Abhijeet Ray ***@***.***> wrote: I can do that but need your views on it to procced or not (people/geeks) — Reply to this email directly, view it on GitHub <#8260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AY446SXS2HHGFME2M7KTC5TXQ6OVXANCNFSM6AAAAAA2PMASTQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[amitthecoder]

Because I am already using bio.link and when I created LinkFree account I realized the bio.link is better, So I want to delete LinkFree account..

…

On Wed, 19 Jul 2023 at 12:28, Eddie Jaoude ***@***.***> wrote: This was coming soon, but we can make it a higher priority. Can I ask why you want to delete your account, not sure what you mean by "some reason"? — Reply to this email directly, view it on GitHub <#8260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AY446SSLETMHI77KM4DPMC3XQ6AR5ANCNFSM6AAAAAA2PMASTQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[eddiejaoude]

Because I am already using bio.link and when I created LinkFree account I realized the bio.link is better, So I want to delete LinkFree account..
…

Could you be more specific @amitthecoder , what is better about bio link so we can make improvements? Thanks

[eddiejaoude]

I can do that but need your views on it to procced or not (people/geeks)

I suggest adding the delete button to the profile edit page, similar to how we have the delete button for events

DELETE EVENTS BUTTON

EDIT PROFILE - delete button can go here next to the save

Use the same process with the confirmation dialogue...

Then on confirmation, change the profile isEnabled to false - we will add a cron later to delete all the data, as we will have lots of stats to delete etc

Does that make sense @abhijeetrayy ?

[webAbhi]

Hi @eddiejaoude if you don't mind can you assign this issue to me ? this look really interesting, i would love to work on this.

[yoyoekta]

We can also add confirmation like, the user need to type in the username to permanently delete profile, to add extra layer of safety?

[vishalsingh2972]

can I work on this if the issue is still open?

[eddiejaoude]

@webAbhi you asked first, so I have assigned it to you

[webAbhi]

@eddiejaoude i think isEnabled flag is not properly handled in backend, when we send isEnabled: false as payload then in response we will receive the value as true, which is weird. i am using the same PUT api which is been used for profile data update. even tried replicating the same thing from postman but getting the same result. BTW i have completed the code for this.

[eddiejaoude]

@eddiejaoude i think isEnabled flag is not properly handled in backend, when we send isEnabled: false as payload then in response we will receive the value as true, which is weird. i am using the same PUT api which is been used for profile data update. even tried replicating the same thing from postman but getting the same result. BTW i have completed the code for this.

Yes you will need to update the API code for the PUT to accept this field and update it.

Also, if an account is disabled, they will need the functionality to enable it also

[webAbhi]

@eddiejaoude i think isEnabled flag is not properly handled in backend, when we send isEnabled: false as payload then in response we will receive the value as true, which is weird. i am using the same PUT api which is been used for profile data update. even tried replicating the same thing from postman but getting the same result. BTW i have completed the code for this.

Yes you will need to update the API code for the PUT to accept this field and update it.

Also, if an account is disabled, they will need the functionality to enable it also

So are we looking to make this API update anytime soon or we need to wait for next deployment ? regarding functionality of enabling a disable profile, you can attach the screenshot where you want to see that. i can add that too in same PR.

[eddiejaoude]

Yes this should be part of this pull request 👍 it does not make sense to be in a separate PR

[webAbhi]

Hey @eddiejaoude, is there any updates on API ?

[eddiejaoude]

@webAbhi what do you mean? I thought you were making the required changes in your pull request?

[webAbhi]

@eddiejaoude okay my bad, but where are we planning to add a button to enable a disabled profile ? How about this page 👇👇?

[eddiejaoude]

@webAbhi I gave an example in a comment 2 weeks ago further up at the beginning of this conversation - here is the directly link to that reply #8260 (comment)

[SaraJaoude]

Due to lack of activity on #8437 I am unassigning and marking this with a staff label as it now has greater priority.

[shivamsethi]

@eddiejaoude - I can work on this one. Can you assign this to me?

[eddiejaoude]

@shivamsethi please don't tag individual maintainers when it is not relevant (as mentioned in our contributing guide), other maintainers can assist also.

Please see the issue label, it is marked as staff only, so only maintainers can work on this issue - you can learn more about our labels in our docs.

[shivamsethi]

Alright Sure :) Thank you :)

[eddiejaoude]

Closing as superseded with issue #9821

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues