This repository has been archived by the owner on May 30, 2023. It is now read-only.
lib: use Cocoapods for Google dependencies resolution #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! I've just noticed the same and fixed it, was about to perform a pull request. Thanks @peterpeterparker. This resolves #613 . |
|
Thanks on behalf of folks who use both plugins 😉- I'll release a new major version because I'm not entirely sure it won't break backward compatibility. |
|
@EddyVerbruggen it's my pleasure, thx you for all your great work 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin couldn't be use in an iOS project where cordova-plugin-firebasex would be use too as both are in conflict.
To resolve the issue, this plugin should use Cocoapods for Google dependencies (see comment from @dpa99c in #553 (comment))