This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
firebase.createUser() returns wrong return type on resolve in android version of code #141
Labels
Milestone
Comments
|
Awesome, James! Thanks in advance 👍 |
jamesehly
added a commit
to jamesehly/nativescript-plugin-firebase
that referenced
this issue
Sep 28, 2016
EddyVerbruggen
added a commit
that referenced
this issue
Sep 28, 2016
Fix return result of createUser function on android version #141
|
Available in 3.7.0. |
EddyVerbruggen
pushed a commit
that referenced
this issue
Apr 18, 2017
EddyVerbruggen
added a commit
that referenced
this issue
Apr 18, 2017
Fix return result of createUser function on android version #141
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The typescript definition declares that createUser should return a type of Promise
export function createUser(options: CreateUserOptions): Promise<CreateUserResult>;The android version of the code is returning a
Promise<User>result via the toLoginResult function. The iOS version of the code returns the correct type of result.I've already fixed this in a local version and will make a pull request for you.
James
The text was updated successfully, but these errors were encountered: