Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom User Agent #21

Closed
andekande opened this issue Dec 18, 2022 · 2 comments
Closed

Custom User Agent #21

andekande opened this issue Dec 18, 2022 · 2 comments

Comments

@andekande
Copy link

Feature Request: In addition to the built in string, allow the user to set one.
Reason: Servers may require a certain content (usually App string) as part of user authentication.

Alternative: Parse the User-Agent from the m3u. Here is the format VLC understands:

#EXTINF:-1 tvg-name="TV Channel 1",TV Channel 1
#EXTVLCOPT:http-user-agent=MYAPP/1.0
http://a.b.c.d:8008/stream.ts|User-Agent=MYAPP/1.0

grafik

EdenwareApps added a commit that referenced this issue Dec 30, 2022
Added support for some more features in M3U playlists:

- #EXTINF type="playlist"
- [color]...[/color]
- #EXTVLCOPT:http-user-agent=? (#21)
- http://a.b.c.d:8008/stream.ts|User-Agent=?
@EdenwareApps
Copy link
Owner

Hi @andekande, thanks for pointing this out. The commit e5eebb7 (release v16.7.6) now brings this improvement. App will recognize both proposed syntaxes.

@andekande
Copy link
Author

andekande commented Jan 4, 2023

Wow, that was a quick implementation.
However, list parsing seems to be broken now as I cant add my m3u.
Also, with the lists I already have imported it didn't work. I Did some code analysis and found this:
e5eebb7#r95076585

The derived classes never pass the new data object in, which renders getDefaultRequestHeaders() useless:
https://github.com/efoxbr/megacubo/blob/master/www/nodejs-project/modules/streamer/adapters/ts.js#L6
https://github.com/efoxbr/megacubo/blob/master/www/nodejs-project/modules/streamer/adapters/aac.js#L6
https://github.com/efoxbr/megacubo/blob/master/www/nodejs-project/modules/streamer/utils/downloader.js#L15
https://github.com/efoxbr/megacubo/blob/master/www/nodejs-project/modules/streamer/utils/proxy-base.js#L6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants