Swiping between screens slow

[unluckyfrog]

Describe the bug

• Swiping to inav lua very slow and not smooth.
• inav lua colours not reproduced correctly.
• When scrolling back to main screen top bar colour has changed.

To Reproduce
update to 2.5.0 rc1 and or 2.5.0 rc2 (tx16s-994c4ff.bin)

Expected behavior
Using inav lua should not change colour on main screen top bar.
Swiping should be smooth(it was in 2.4)
inav lua should work. It does in 2.4 but in 2.5 the fonts are all incorrect.
Re-flashing to 2.4 solves the issue.

Screenshots

20210928_082618_1_1.mp4

General information

• EdgeTX version 2.5.0 rc 1/2
• Hardware Tx16s

[pfeerick]

Looks like something went wrong with the video upload.

Top bar colour is a known issue, and requires changes in the iNav lua script to not set colours the way it does. Please check you are running the current version of the widget, as the PR to resolve this was merged yesterday, and there is a new release including it ;)

https://github.com/iNavFlight/OpenTX-Telemetry-Widget/releases/tag/v2.0.0

[pfeerick]

Update: I've just installed it myself as I use the iNav lua with on of my models, and it does fix the issue with messing with system theme colour settings and inav colours. The slow scrolling when using touch may just have to be something we live with for now... there is just a minor delay if you use the hardware page scroll buttons when switching to it, but it doesn't have any slide glitches.

[unluckyfrog]

Yep just uploaded new version of inav lua and working well. Still slow scroll but pg buttons work. Thanks

…

On Tue, 28 Sep 2021, 11:08 am Peter Feerick, ***@***.***> wrote: Update: I've just installed it myself as I use the iNav lua with on of my models, and it does fix the issue with messing with system theme colour settings and inav colours. The slow scrolling when using touch may just have to be something we live with for now... there is just a minor delay if you use the hardware page scroll buttons when switching to it, but it doesn't have any slide glitches. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANTBKAHUNF56CCAN3JKU6HTUEEISXANCNFSM5E3VENLA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[JimB40]

If I may suggest. Use own independent color table instead of ETX constants. Inav uses own constant colors independent of OS system colors anyway. So it's much better to define them as variables holding 24bit hex 0xRRGGBB values or proper color flags inside script.
We still work on ETX on UI so color constant names and assignment to UI elements may change.

[stronnag]

Thanks for the suggestion; I started on that path, and due no doubt to my inexperience with the project and lua ended up with issues between ETX and OTX. The current approach was pragmatic to get something working on both platforms.

I'll maybe revisit it. The whole inav widget could benefit from significant re-factoring in any case.

[JimB40]

If you want keep it as flags (faster)

local COLORS = {
BLACK = lcd.RGB(0x000000),
GRAY = lcd.RGB(0x808080),
RED = lcd.RGB(0xFF0000),
}

lcd.drawText(0,0,"Sample Midsized Gray Text", COLORS.GRAY+MIDSIZE)
-- sample red rectangle
lcd.drawFilledRectangle(10,10,100,200,COLORS.RED)

this technique is not cross-compatible with OTX

[stronnag]

this technique is not cross-compatible with OTX

Unfortunately, we need to remain compatible with OTX.
Maybe we'll end up with a colour table approach that abuses / restores system flags / theme for OTX and behaves nicely for ETX.

[JimB40]

OTX needs to set this CUSTOM_COLOR every time so I used proxy function that returns CUSTOM_COLOR with proper color if on OTX or proper color flag value if on ETX. And to simplify LUA code you can use metatable to swap colors' table access behavior from value to function output if on OTX

[stronnag]

That's pretty much where the inav widget is going as well.

[stronnag]

WIP, but much improved scrolling speed, shouldn't touch the system theme on Edge
https://github.com/stronnag/inav-EdgeTX-OpenTX-Telemetry-Widget/releases/tag/2.0.1

[unluckyfrog]

Just loaded. Awesome thx

…

On Wed, 29 Sep 2021, 11:34 pm Jonathan Hudson, ***@***.***> wrote: WIP, but much improved scrolling speed, shouldn't touch the system theme on Edge https://github.com/stronnag/inav-EdgeTX-OpenTX-Telemetry-Widget/releases/tag/2.0.1 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANTBKAA2GENFNXP2HRSTZILUEMIVNANCNFSM5E3VENLA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[pfeerick]

Oh my... just tried it out... I think the speed is back to normal, so it's just the animation now :) So I think this is now resolved, but may still get even better? 😁

[stronnag]

We've merged iNavFlight/OpenTX-Telemetry-Widget#13 into the inav lua widget master, so we're done for now.
@pfeerick please elaborate on "it's just the animation now".
You can probably close this and add any further comments on the inav lua github.

[pfeerick]

@stronnag Sure... "just the animation now" as in... the only delay is the actual swipe animation... I don't see any real delay that I could attribute to the Lua script anymore. Thank you for this, it looks great, and I'll be properly testing it out tomorrow when flying :)