Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): hardware and internal module antenna parameters #3050

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jan 16, 2023

Fixes #2383

Summary of changes:

  • align Companion with X10/X12S: Int/Ext Antenna UI #1765
  • hardware
    -- move antenna to within Internal RF section
    -- code housekeeping
  • model setup
    -- Internal module fix when to display antenna parameter
    -- fix antenna dropdown list sequence
  • boards fix external antenna

Tested on a few libsims

@elecpower elecpower added bug 🪲 Something isn't working companion Related to the companion software labels Jan 16, 2023
@pfeerick pfeerick self-assigned this Feb 3, 2023
@pfeerick pfeerick added this to the 2.9 milestone Feb 3, 2023
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Neil! :)

@pfeerick pfeerick merged commit 8ee0336 into main Feb 27, 2023
@pfeerick pfeerick deleted the elecpower/cpn-antennas branch February 27, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion treating X12S ACCESS ISRM like XJT
2 participants