Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X10/X12S: Int/Ext Antenna UI #1765

Merged
merged 3 commits into from
Oct 11, 2022
Merged

X10/X12S: Int/Ext Antenna UI #1765

merged 3 commits into from
Oct 11, 2022

Conversation

pfeerick
Copy link
Member

@pfeerick pfeerick commented Mar 30, 2022 •
edited
Loading

Fixes #1567

Summary of changes:

  • implements UI for internal/external antenna selection

And for prosperity/full transparency, I started this, but Raphael finished it ... you just can't see he finished re-writing the remainder of it due to the rebase. ;)

USE AT YOUR OWN RISK until properly tested! (aka have both antenna fitted until this warning removed).

@pfeerick pfeerick linked an issue Apr 19, 2022 that may be closed by this pull request
X10/S: Antenna configuration options missing #1185
Closed
@pfeerick
Copy link
Member Author

pfeerick commented Jul 1, 2022

Rebased to adjust for LVGL. However I haven't implemented colorlcd/hw_intmodule.cpp quite right as it doesn't show crossfire or antenna options when applicable. Entirely my own fault as still haven't looked at how things are done in hybrid LVGL/libopenui land.

@pfeerick pfeerick added this to the 2.9 milestone Sep 7, 2022
@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review September 25, 2022 09:53
@raphaelcoeffic raphaelcoeffic changed the title X10: Int/Ext Antenna UI X10/X12S: Int/Ext Antenna UI Sep 25, 2022
@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour needs: testing labels Sep 25, 2022
@raphaelcoeffic raphaelcoeffic mentioned this pull request Sep 25, 2022
Closed
1 task
@pfeerick pfeerick linked an issue Sep 26, 2022 that may be closed by this pull request
Some issues to fix on Frsky Horus X12S #2108
Closed
1 task
@pfeerick pfeerick mentioned this pull request Sep 30, 2022
Closed
1 task
@pfeerick pfeerick modified the milestones: 2.9, 2.8 Oct 2, 2022
@pfeerick pfeerick merged commit e90cd0f into main Oct 11, 2022
@pfeerick pfeerick deleted the pfeerick/issue1567 branch October 11, 2022 11:48
pfeerick added a commit that referenced this pull request Oct 12, 2022
@pfeerick @raphaelcoeffic
feat(X10/X12S) Int/Ext Antenna UI (#1765)
25aedc2 
* feature(colorlcd): antenna selection

* fix: let's assume all internal XJT modules used in horus targets are either X10 or X12S type

* fix NV14 compilation

Co-authored-by: Raphael Coeffic <raphael.coeffic@frafos.com>
@elecpower elecpower mentioned this pull request Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelcoeffic raphaelcoeffic raphaelcoeffic left review comments

Assignees
No one assigned
Labels
color Related generally to color LCD radios needs: testing UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.8
2 participants
@pfeerick @raphaelcoeffic