Companion treating X12S ACCESS ISRM like XJT

[rburrow87]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

I just realized I never submitted this as a bug and was probably forgotten in a PR comment from a while back #2019 (comment)

Okay now that you made me look at my old post, maybe it's caused by something else 😛 Almost seems like it's treating the X12S like the internal module is set to XJT instead of ISRM even though it's set to ISRM.

This is what the X12S ISRM radio writes:

moduleData: 
  0:
     type: TYPE_ISRM_PXX2
     subType: ACCESS
     channelsStart: 0
     channelsCount: 16
     failsafeMode: NOPULSES
     mod: 
        pxx2: 
           receivers: 0
           racingMode: 0
           receiverName: 
              0:
                 val: "SR6"

This is how Companion 2.8 reads it in (notice it offers the Antenna option as if it's treating it like the internal module is set to XJT and not ISRM (and I made sure it's set to ISRM)):

So this is how Companion 2.8 writes it back out:

moduleData:
 0:
   type: TYPE_ISRM_PXX2
   subType: ACCESS
   channelsStart: 0
   channelsCount: 16
   failsafeMode: NOPULSES
   mod:
     pxx2:
       receivers: 0
       racingMode: 0

But Companion 2.8 still reads in and writes out fine with my X9D+2019:

Version

Nightly (Please give date/commit below)

Transmitter

FrSky X12 w/ISRM upgrade

[elecpower]

There is also a reference to antenna in Radio Settings hardware tab that does not appear in the radio simulator

This is displayed based on

case HasAntennaChoice:
      return ((IS_FAMILY_HORUS_OR_T16(board) && board != Board::BOARD_X10_EXPRESS) || (IS_TARANIS_XLITE(board) && !IS_TARANIS_XLITES(board))) ? true : false;

The model setup antenna is displayed based on

        if (moduleIdx == 0 && HAS_EXTERNAL_ANTENNA(board) && generalSettings.antennaMode == GeneralSettings::ANTENNA_MODE_PER_MODEL)
          mask |= MASK_ANTENNA;

inline bool HAS_EXTERNAL_ANTENNA(Board::Type board)
{
  return (board == Board::BOARD_X10 || board == Board::BOARD_HORUS_X12S || (IS_TARANIS_XLITE(board) && !IS_TARANIS_XLITES(board)));
}

So I need some guidance here as to the rules to apply in Radio Settings and Model Setup Internal Module before tackling a fix.

[pfeerick]

Need to consider #1765 and associated issue #1185 for that latter point I think.

[elecpower]

Looks like best for me to wait until 1765 is merged and see what Companion tweaks are necessary to match the radios