Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DSM Tel) Fix for Spektrum GPS Sensor #3366

Merged
merged 4 commits into from
Mar 23, 2023
Merged

fix(DSM Tel) Fix for Spektrum GPS Sensor #3366

merged 4 commits into from
Mar 23, 2023

Conversation

frankiearzu
Copy link
Contributor

@frankiearzu frankiearzu commented Mar 17, 2023 •
edited
Loading

Fix for #3290
Summary of changes:

  1. The BCD conversions was totally wrong. The only code that used BCD was for JETCATS sensor. I don't think that it ever worked with that BCD conversion.
  2. Added support for the Spektrum GPS sensor
  3. Populated the Flight Mode sensor based on AS3X/SAFE information (AR631,etc)
  4. Populated the Flight Mode sensor based on Alpha6 information (Blade Heli Controllers based on AR636)

screen-GPS
screen-FM

@frankiearzu
EdgeTX#3290 Fix for GSP
72bf9ee 
* Fix GPS Telemetry problem.

* Added FlightMode for some RX   (AS3X and ALPHA6-BLADE)
@frankiearzu
EdgeTX#3290
214706c 
Fix small problems.
@frankiearzu
Add adjustment for TimeZone
4cbe85d 
Add adjustment for TimeZone
@frankiearzu frankiearzu changed the title #3290 Fix for Spektrum GPS Sensor (DSM Telemetry) Fix for Spektrum GPS Sensor Mar 18, 2023
@frankiearzu frankiearzu changed the title (DSM Telemetry) Fix for Spektrum GPS Sensor (fix) Fix for Spektrum GPS Sensor Mar 18, 2023
@frankiearzu frankiearzu changed the title (fix) Fix for Spektrum GPS Sensor fix(DSM Tel) Fix for Spektrum GPS Sensor Mar 18, 2023
@frankiearzu frankiearzu mentioned this pull request Mar 19, 2023
Closed
1 task
@frankiearzu
Copy link
Contributor Author

Fix validated by 3rd party who owns the sensor.
Check last comments on the issue: #3290

@pfeerick pfeerick added this to the 2.9 milestone Mar 22, 2023
@pfeerick pfeerick merged commit edd4696 into EdgeTX:main Mar 23, 2023
@pfeerick pfeerick linked an issue Mar 23, 2023 that may be closed by this pull request
DSM GPS telemetry not working #3290
Closed
1 task
@frankiearzu frankiearzu deleted the DSMGPSFix branch May 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
telemetry 📶
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

DSM GPS telemetry not working
2 participants
@frankiearzu @pfeerick