Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): selection of sound packs in update process #3848

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Jul 23, 2023

Fixes #3841

Summary of changes:

  • refactor asset filtering to not use sounds.json file but instead filter the release assets
  • only 1 pack can be downloaded per run as all language variants share the same destination directory
  • supporting functions
  • housekeeping

Screenshot from 2023-07-24 09-32-06

Due to a change to the asset filter a release note is required as only 1 zip file will be found for each language with the old filter:
Steps:

  1. Launch Companion
  2. Select Settings
  3. Select Update Settings tab
  4. Click Sounds component Options button
  5. Edit the Filter pattern by DELETING the trailing hypen
  6. Click OK to save the change
  7. Click OK to exit the Settings

Screenshot from 2023-07-24 09-37-45

@elecpower elecpower added companion Related to the companion software bug/regression ↩️ A new version of EdgeTX broke something labels Jul 23, 2023
@elecpower elecpower marked this pull request as draft July 23, 2023 23:12
@elecpower elecpower added the rn: warning Warning needed in release notes label Jul 23, 2023
@elecpower elecpower marked this pull request as ready for review July 23, 2023 23:30
@elecpower elecpower force-pushed the elecpower/cpn-fix-3841-sound-packs branch from 185bed8 to f5f3aad Compare August 29, 2023 11:18
@pfeerick pfeerick self-requested a review September 4, 2023 03:46
@pfeerick pfeerick added this to the 2.10 milestone Sep 7, 2023
@pfeerick
Copy link
Member

pfeerick commented Sep 7, 2023

There may be an issue where you have run the updater twice in a row, and pick a different sound pack each time? It prompts you to download it again, and then unpacks it. Although, unrelated to this PR it seems as I can get something similar to happen with 2.9.0. Otherwise seems to be working (Windows 11, EN packs).

@pfeerick pfeerick merged commit fec64a9 into main Sep 7, 2023
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-fix-3841-sound-packs branch September 7, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something companion Related to the companion software rn: warning Warning needed in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion Soundpack Download, loads always the same file
2 participants