-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: SD card SPI HAL #3957
Conversation
c571791
to
5d65703
Compare
@raphaelcoeffic I think you may need to consider this PR as well. Change in SD card specific functions may breaks Virtual FS. |
Probably, yes. I will need to rebase / port on top of this PR as soon as I have tested and fixed it. The plan we had with @gagarinlg was to adopt a more generic FatFs driver as the first layer similar to this: https://github.com/STMicroelectronics/stm32_mw_fatfs/blob/master/src/ff_gen_drv.h |
51620bf
to
a27b1be
Compare
Did run some test in T20 (because of the SD chip instead of card)
|
Also tested on X7 (for the F2 processor, SD is a no name 32Gb class 10 card) no issue found at all |
Tested now on X7 with 256MB card supplied with another radio:
SAME card directly connected to PC with a SDCard adapter:
Errors are mysteriously gone in radio after the sd card reformat, something strange is at play since something similar happened to Raph |
Test on X7 (F2) : all ok, despite using the dreadful no name sd (tested mass storage and BL mode) |
20b6a22
to
03b066c
Compare
Ok now :) |
03b066c
to
54c1321
Compare
X9D+2019: Flashed FW and BL, twice. Navigating SD, renaming, deleting fine. Models and radio settings intact. Able to copy files and make changes via USB when radio in BL or running main firmware. Able to update ISRM via SD. Able to run standalone lua from SD. BetaFPV LR3: Same as above (except for ISRM update obviously). EL18: DFU flashed firmware as one trim hat borked with repeated bootloader flashes 🤭, otherwise everything seems to be working as above. |
This PR breaks audio playback on my EL18 - no sounds can be played from the SOUNDS folder. No startup sound played, no sounds played by scripts or special functions and sound does not play if manually selected from the file browser. TX16 is not affected, only broken on EL18. |
Summary of changes:
diskio
API (similar to ST's middleware)