Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pl18): Audio playback hiccup problem when SPI flash is writing #4476

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

richardclli
Copy link
Collaborator

PL18 has intermittent audio playback, just try to fine tune to see if anything helps

@richardclli richardclli marked this pull request as draft December 28, 2023 06:08
@richardclli richardclli added this to the 2.10 milestone Dec 28, 2023
@richardclli richardclli self-assigned this Dec 28, 2023
@richardclli
Copy link
Collaborator Author

richardclli commented Dec 28, 2023

Need some more testing to see if it can solve the hiccup sound

@richardclli richardclli marked this pull request as ready for review December 28, 2023 07:12
@richardclli richardclli marked this pull request as draft December 29, 2023 06:34
@richardclli richardclli changed the title fix(pl18): Intermittent audio playback fix(pl18): Audio playback hiccup problem when SPI flash is writing Dec 30, 2023
@richardclli richardclli marked this pull request as ready for review December 30, 2023 03:34
@richardclli
Copy link
Collaborator Author

This seems to resolves the sound hiccup problem, with the PR that improves the SPI flash read performance:
#4478

@pfeerick pfeerick added bug 🪲 Something isn't working sound 🔉 Related to generated or played audio/sound labels Dec 31, 2023
@pfeerick pfeerick merged commit 6dc6ed5 into main Dec 31, 2023
39 checks passed
@pfeerick pfeerick deleted the improve-pl18-audio branch December 31, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working sound 🔉 Related to generated or played audio/sound
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants