Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): crash when going into radio settings due to customisable switch groups source #5141

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jun 9, 2024

Fixes:

  • Companion crashes when editing radio settings for radios without function switches.
  • Add GRx sources to switch filter when selecting a source (color radios).

screenshot_t15_24-06-09_21-59-32

@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Jun 9, 2024
@pfeerick pfeerick changed the title fix(radio,cpn): issues with customisable switch generated source groups fix(cpn): crash when going into radio settings for radios without customisable switches Jun 9, 2024
@pfeerick
Copy link
Member

pfeerick commented Jun 9, 2024

I don't think this is the complete fix... as it crashed for both radio with and without cusotmisable switches ... and still does for radios with customisable switches... e.g. TPro ;)

@pfeerick pfeerick added this to the 2.11 milestone Jun 10, 2024
@pfeerick
Copy link
Member

Thank you!... that got it. And I think that just opened up another can of worms in Companion (and possibly radio, need to check that now)... whereby model specific switches are showing up for global functions... so probably need to start working on #4333 again 🤣

@pfeerick pfeerick changed the title fix(cpn): crash when going into radio settings for radios without customisable switches fix(cpn): crash when going into radio settings due to customisable switch groups source Jun 10, 2024
@pfeerick pfeerick merged commit aa87148 into main Jun 10, 2024
48 checks passed
@pfeerick pfeerick deleted the philmoz/fix-gen-src-grps branch June 10, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants