Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bw): unable to select GV as source for weight/offset/curve in input/mix #5386

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix(bw): unable to select GV as source for weight/offset/curve in input/mix #5386

merged 1 commit into from
Aug 7, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Aug 5, 2024 •
edited by pfeerick
Loading

Fixes for B&W radios from PR #5220:

  • Fix source selection for weight/offset/curve to allow GV selection.
  • Allow GV as source for mixer lines.
  • Filter empty categories from source select popup.

Fixes #4007

@philmoz philmoz added this to the 2.11 milestone Aug 5, 2024
@philmoz philmoz added UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Aug 5, 2024
@philmoz
Copy link
Collaborator Author

philmoz commented Aug 5, 2024

Also fixes #4007

@pfeerick pfeerick changed the title fix(b&w): unable to select GV as source value for weight/offset/curve in input and mix line. fix(bw): unable to select GV as source value for weight/offset/curve in input and mix line Aug 5, 2024
@pfeerick pfeerick changed the title fix(bw): unable to select GV as source value for weight/offset/curve in input and mix line fix(bw): unable to select GV as source for weight/offset/curve in input/mix Aug 6, 2024
@pfeerick pfeerick self-requested a review August 6, 2024 01:52
Fix source selection for weight/offset/curve to allow GV selection. A…
adb712b 
…llow GV as source for mixer lines. Filter empty categories from source select popup.
@philmoz philmoz force-pushed the philmoz/bw-fix-source-select branch from 0448546 to adb712b Compare August 6, 2024 10:41
pfeerick
pfeerick approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after trying out Pocket, TLite, X9D+ (and TX16 since this touches common code).

@pfeerick pfeerick merged commit 5e745df into main Aug 7, 2024
47 checks passed
@pfeerick pfeerick deleted the philmoz/bw-fix-source-select branch August 7, 2024 10:07
This was referenced Aug 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Allow Global Variables as source for Inputs & Mixers
2 participants
@philmoz @pfeerick