Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow an 'input' as the source for weight, offset and curve in input line #5418

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Aug 11, 2024

Extending the changes from PR #5220 this change allows the source for weight, offset and curve in an Input line to be another Input.

Reasoning behind this is I want to use a slider to fine tune the expo for a control.
I create an input for the slider and use weight and offset to control the range of values.

Currently to use this 'expo' input to control Expo on a stick input I need to add a mix line and then use the output channel - which over complicates things.

TODO:

  • Companion support

@philmoz philmoz added enhancement ✨ New feature or request color Related generally to color LCD radios B&W Related generally to black and white LCD radios labels Aug 11, 2024
@philmoz philmoz added this to the 2.11 milestone Aug 11, 2024
@pfeerick pfeerick changed the title feat(radio): allow an 'input' as the source for weight, offset and curve in input line. feat: allow an 'input' as the source for weight, offset and curve in input line Aug 13, 2024
@philmoz philmoz force-pushed the philmoz/allow-input-as-source branch from 783f5d6 to ef0a043 Compare August 13, 2024 11:27
@pfeerick pfeerick self-requested a review August 14, 2024 00:04
@pfeerick
Copy link
Member

Very nice! :)

@pfeerick pfeerick merged commit 1024717 into main Aug 14, 2024
50 checks passed
@pfeerick pfeerick deleted the philmoz/allow-input-as-source branch August 14, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios color Related generally to color LCD radios enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants