Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bw] set multi binding mode only if multimodule #820

Merged
merged 1 commit into from
Sep 29, 2021
Merged

[bw] set multi binding mode only if multimodule #820

merged 1 commit into from
Sep 29, 2021

Conversation

raphaelcoeffic
Copy link
Member

This should fix the annoying sound continuing after binding has been completed on D8 / D16 internal XJT (and maybe others).

@raphaelcoeffic raphaelcoeffic linked an issue Sep 27, 2021 that may be closed by this pull request
There is no way to exit full screen widget on the RX without HW keys. (NV14) #821
Open
@raphaelcoeffic raphaelcoeffic removed a link to an issue Sep 27, 2021
There is no way to exit full screen widget on the RX without HW keys. (NV14) #821
Open
@raphaelcoeffic raphaelcoeffic linked an issue Sep 27, 2021 that may be closed by this pull request
Binding beeping don't stop after binding #819
Closed
@raphaelcoeffic raphaelcoeffic mentioned this pull request Sep 27, 2021
Closed
pfeerick
pfeerick approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TX12 with external XJT, previously beeped constantly, now stops beeping stops when bind stopped
  • X9D+2019 with internal XJT, previously beeped, now stops when bind stopped

@pfeerick pfeerick added this to the 2.5 milestone Sep 28, 2021
@raphaelcoeffic raphaelcoeffic merged commit bb4eedd into main Sep 29, 2021
@pfeerick pfeerick deleted the fix-bind-beep branch September 30, 2021 00:01
@jims1234 jims1234 mentioned this pull request Jul 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

Binding beeping don't stop after binding
2 participants
@raphaelcoeffic @pfeerick