Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer-2 Headers of Spanning-Tree #1

Closed
jpan613 opened this issue Mar 13, 2017 · 3 comments
Closed

Layer-2 Headers of Spanning-Tree #1

jpan613 opened this issue Mar 13, 2017 · 3 comments

Comments

@jpan613
Copy link

jpan613 commented Mar 13, 2017

I noticed an edge case in sampled STP layer-2 header, where the source and destination mac addresses are followed by length instead of ethertype (because STP doesn't have an ethertype), and as a result, length (usually 105) is reported as the ethertype.
I guess one way to get around it is to use the source or destination mac address, which s 01:80:c2:00:00:00 for STP, to identify this edge case.

@mehrdadrad
Copy link
Collaborator

@jpan613 are you talking about the sflow and the below?
https://github.com/VerizonDigital/vflow/blob/master/packet/ethernet.go#L106

@jpan613
Copy link
Author

jpan613 commented Mar 29, 2017

@mehrdadrad exactly

@mehrdadrad
Copy link
Collaborator

@jpan613 as the ethernet and IP networks are most popular and we need to deep dive on their flow, The vFlow does only ethernet -> IPv4/IPv6 -> UDP/TCP decoding (sFlow) for the time being.
If anyone needs other protocols like STP they can create a PR.

mehrdadrad pushed a commit that referenced this issue Jan 9, 2019
Bring Verizon's changes into my codebase
alexeigr pushed a commit to alexeigr/vflow that referenced this issue Jan 24, 2019
…ps-recieving-flows-after-pcap-pattern to master

* commit '5063df418a9807d2ddc77e992fc775ac363d3ff4':
  handling corrupted template data
  handling corrupted template data
  handling corrupted template data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants