Add section ordering for rsmexplain
#667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `section_order` as a valid field for `rsmexplain`. - Use `section_order` for rsmexplain reports, if available.
- Since the auto cohorts notebook is a self-contained section, its heading levels should reflect that irrespective of where in the notebook it's included.
- Add explicit note about auto cohorts section being a custom section and how to order it. - Add more anchors and rename existing anchors to be consistent.
desilinguist
requested review from
mulhod,
Frost45,
damien2012eng and
tamarl08
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 32 32
Lines 4488 4489 +1
=======================================
+ Hits 4301 4302 +1
Misses 187 187 ☔ View full report in Codecov by Sentry. |
tamarl08
reviewed
Jan 4, 2024
tamarl08
reviewed
Jan 4, 2024
tamarl08
reviewed
Jan 4, 2024
Those plots cannot be generated for a single example.
desilinguist
force-pushed
the
665-fix-auto-cohort-plots
branch
from
7585ada
to
23e12ea
Compare
tamarl08
approved these changes
Jan 5, 2024
damien2012eng
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsmexplainnow supportssection_orderfield in its configuration.rsmexplaindocumentation to add a note about the auto cohorts section and its order.