-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints (Part 3) #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, refactor `FeaturePreprocessor.filter_on_column()` to remove unused argument `id_column`.
Also, refactor `DataReader.locate_files()` in `reader.py` to always return a list instead of a string OR a list which was strange and problematic when it came to adding type hints.
desilinguist
requested review from
mulhod,
Frost45,
damien2012eng and
tamarl08
February 5, 2024 17:05
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 96.14% 96.09% -0.05%
==========================================
Files 32 32
Lines 4483 4505 +22
==========================================
+ Hits 4310 4329 +19
- Misses 173 176 +3 ☔ View full report in Codecov by Sentry. |
We can ignore the coverage failure. |
tamarl08
reviewed
Feb 5, 2024
desilinguist
force-pushed
the
326-type-hints-3
branch
from
February 5, 2024 19:49
fadabb9
to
9aafeeb
Compare
tamarl08
reviewed
Feb 5, 2024
mulhod
approved these changes
Feb 5, 2024
desilinguist
force-pushed
the
326-type-hints-3
branch
from
February 5, 2024 22:38
6d33b7f
to
c88f820
Compare
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
tamarl08
reviewed
Feb 6, 2024
desilinguist
force-pushed
the
326-type-hints-3
branch
from
February 6, 2024 19:41
e58ce94
to
ab3aa7b
Compare
desilinguist
force-pushed
the
326-type-hints-3
branch
from
February 6, 2024 20:10
ab3aa7b
to
5360bc1
Compare
tamarl08
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
statsmodels
intersphinx mapping for documentation.fairness_utils.py
.modeler.py
.preprocessor.py
.reader.py
reader.py
.Note that in this MR, I also did some refactoring:
id_column
argument inFeaturePreprocessor.filter_on_column()
.DataReader.locate_files()
to always return list of string instead of either a string or a list of strings +None
s which was confusing and also caused issues when adding type hints.DataReader
.How to review