-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type Hints (Final Part) #683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desilinguist
requested review from
mulhod,
Frost45,
damien2012eng and
tamarl08
February 12, 2024 23:25
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 32 32
Lines 4517 4546 +29
=======================================
+ Hits 4341 4369 +28
- Misses 176 177 +1 ☔ View full report in Codecov by Sentry. |
damien2012eng
approved these changes
Feb 13, 2024
mulhod
approved these changes
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
tamarl08
reviewed
Feb 14, 2024
@desilinguist done! :) |
Thank you so much for the careful review, @tamarl08! 🙇🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
utils.commandline
utils.conversion
utils.cross_validation
utils.files
utils.logging
utils.metrics
utils.models
utils.notebook
utils.prmse
.utils.wandb
How to review