Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Hints (Final Part) #683

Merged
merged 14 commits into from
Feb 14, 2024
Merged

Add Type Hints (Final Part) #683

merged 14 commits into from
Feb 14, 2024

Conversation

desilinguist
Copy link
Member

Changes

  • Add intersphinx mapping for prompt_toolkit
  • Add type hints for utils.commandline
  • Add type hints for utils.conversion
  • Add type hints for utils.cross_validation
  • Add type hints for utils.files
  • Add type hints for utils.logging
  • Add type hints for utils.metrics
  • Add type hints for utils.models
  • Add type hints for utils.notebook
  • Add type hints for utils.prmse.
  • Add type hints for utils.wandb

How to review

  • Please check that I have not left any parameters/arguments/return values without type hints.
  • Please check that the types in the docstrings match those in the actual code.
  • Here's the RTD build for this branch. Check the "API Documentation" section (for the files affected by this MR) to confirm that all types are linked to relevant pages from external documentations (e.g., Python, Numpy, SKLL, stats models etc.) and there are no typos etc.
  • Check for typos and/or weird issues in docstrings.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (32b91b7) 96.10% compared to head (0239498) 96.10%.

Files Patch % Lines
rsmtool/utils/cross_validation.py 85.71% 1 Missing ⚠️
rsmtool/utils/prmse.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #683   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files          32       32           
  Lines        4517     4546   +29     
=======================================
+ Hits         4341     4369   +28     
- Misses        176      177    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rsmtool/utils/notebook.py Outdated Show resolved Hide resolved
rsmtool/utils/wandb.py Outdated Show resolved Hide resolved
@tamarl08
Copy link
Contributor

@desilinguist done! :)

@desilinguist
Copy link
Member Author

Thank you so much for the careful review, @tamarl08! 🙇🏽

@desilinguist desilinguist linked an issue Feb 14, 2024 that may be closed by this pull request
@desilinguist desilinguist merged commit 007b72d into main Feb 14, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 326-type-hints-5 branch February 14, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type hints and type checking
4 participants