Feature/save cv folds #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config_dir = join(_my_dir, 'configs') | ||
|
|
||
| cfg_file = join(config_dir, 'test_save_cv_folds.cfg') | ||
| os.unlink(cfg_file) |
There was a problem hiding this comment.
Just wondering: Is there some specific reason we're using unlink here as opposed to remove or is it just because that's what has been used in the past? The docs say that it's identical to remove and it seems like the naming is clearer there.
There was a problem hiding this comment.
It's just a consistency thing. We have been using unlink in the past.
| @@ -363,6 +365,9 @@ def _parse_config_file(config_path): | |||
| # default number of cross-validation folds | |||
| cv_folds = 10 | |||
|
|
|||
| # whether or not to save the cv fold ids | |||
| save_cv_folds = config.get("Input", "save_cv_folds") | |||
There was a problem hiding this comment.
I think this belongs in Output, since this an option that relates to what we're outputting, and not to what we're given.
|
This looks pretty good to me. I am going to merge it tomorrow unless anyone else has an objection. |
desilinguist
added a commit
that referenced
this pull request
Dec 11, 2015
…v_folds Feature/save cv folds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config option that saves information about which example was in which test fold during cross validation experiments. The name of the file is fixed for each experiment.