-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/cv folds file logging #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @Lguyogiro!
I've pushed one more minor change: previously the experiment name (in the config file) for testing the cv folds file logging was "test_save_cv_folds". I've updated to reflect what it is actually testing. |
Since this is a very simple change, I am just going to merge it now without waiting for another approval. |
cv_folds_file
#349 . Previously,cv_folds
was assumed to be an int. But if "cv_folds_file" is specified in the config,cv_folds
will be a dictionary mapping ids to fold numbers and requires new code to correctly log the number of folds.cv_folds
and, if it is not an int, logging the number of unique fold ids from the dict values.tests/train/
andtest_cv_folds_file_logging
to test suite