Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README/Tutorial/Badges #399

Merged
merged 7 commits into from
Dec 13, 2017
Merged

Update README/Tutorial/Badges #399

merged 7 commits into from
Dec 13, 2017

Conversation

desilinguist
Copy link
Member

  • Update tutorial to show new log, new results and new config.
  • Update readme with new badges.
  • Minor updates to some other documentation, e.g., about learning curves and new installation instructions.

@desilinguist desilinguist added this to the 1.5 milestone Dec 12, 2017
@desilinguist desilinguist self-assigned this Dec 12, 2017
@coveralls
Copy link

coveralls commented Dec 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.523% when pulling 2b8f31a on update-readme-tutorial-badges into 4db4392 on master.

@desilinguist
Copy link
Member Author

This branch is now ready for review.

Lguyogiro
Lguyogiro reviewed Dec 12, 2017
View reviewed changes
README.rst
:target: https://anaconda.org/desilinguist/skll
:alt: Conda package for SKLL

.. image:: https://img.shields.io/pypi/pyversions/skll.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image only lists 2.7, 3.3, and 3.4. Don't we support up to 3.6 at this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's automatically derived from PyPI so once the new package is uploaded with the new setup.py, the badge should change to 2.7 and 3.6.

Lguyogiro
Lguyogiro approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@Lguyogiro Lguyogiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG to me

@desilinguist desilinguist merged commit 37f7d29 into master Dec 13, 2017
@desilinguist desilinguist deleted the update-readme-tutorial-badges branch December 13, 2017 00:52
This was referenced Dec 13, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoifecahill aoifecahill aoifecahill approved these changes

@Lguyogiro Lguyogiro Lguyogiro approved these changes

@jbiggsets jbiggsets jbiggsets approved these changes

Assignees

@desilinguist desilinguist

Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@desilinguist @coveralls @aoifecahill @Lguyogiro @jbiggsets