Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scikit-learn to v0.20.1 #439

Merged
merged 8 commits into from
Dec 4, 2018
Merged

Update scikit-learn to v0.20.1 #439

merged 8 commits into from
Dec 4, 2018

Conversation

desilinguist
Copy link
Member

@desilinguist desilinguist commented Dec 3, 2018 •
edited
Loading

  • Update scikit-learn version in various requirement files.
  • Update version in conda-recipe.
  • Update version in .travis.yaml.
  • Make minor changes to hyperparameters and parameter names necessitated by the version change.
  • Update the expected values for a couple of tests - these are necessitated due to upstream changes and bug fixes in the MLP and Gradient Boosted models.

@desilinguist
Update scikit-learn versions in all requirements files.
cde66dd
@desilinguist
Fix numpy deprecation.
fcb1058
@desilinguist
Update expected values due to changes in MLP
19762be
@desilinguist
Add new default parameter values
f61a220 
- These are based on sklearn defaults that will be set in the near future.
@desilinguist
Change SGD hyperparameters back to old values
fed848d 
- We want to retain backwards compatbility as much as possible so we will let the FutureWarnings come out so that the user is aware that a change is coming in a subsequent release.
@desilinguist
Rename seaborn size parameter to height
b5c66e8
@desilinguist
Update GradientBoosting feature importances
fcb2c85 
 - due to upstream bugfix in scikit-learn
@desilinguist
update travis to use latest sklearn
e78fb28
@desilinguist desilinguist self-assigned this Dec 3, 2018
@coveralls
Copy link

coveralls commented Dec 3, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 92.267% when pulling e78fb28 on update-scikit-learn into fc37bc7 on master.

@desilinguist
Copy link
Member Author

The tiny change in coverage can be ignored - it’s only to do with the 2 or 3 added lines explicitly setting default values of hyperparameters that’s required by 0.20.1.

jbiggsets
jbiggsets approved these changes Dec 4, 2018
View reviewed changes
Copy link
Collaborator

@jbiggsets jbiggsets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@desilinguist desilinguist merged commit 48e5f1f into master Dec 4, 2018
@desilinguist desilinguist deleted the update-scikit-learn branch December 4, 2018 16:41
@desilinguist desilinguist mentioned this pull request Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiggsets jbiggsets jbiggsets approved these changes

@Lguyogiro Lguyogiro Lguyogiro approved these changes

@mulhod mulhod mulhod approved these changes

Assignees

@desilinguist desilinguist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@desilinguist @coveralls @mulhod @Lguyogiro @jbiggsets