Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle combination of model and data vectorizers in Learner.predict() #445

Merged
merged 7 commits into from
Dec 12, 2018
Merged

Handle combination of model and data vectorizers in Learner.predict() #445

merged 7 commits into from
Dec 12, 2018

Conversation

desilinguist
Copy link
Member

@desilinguist desilinguist commented Dec 12, 2018 •
edited
Loading

This PR modifies Learner.predict() to handle the 4 combinations of possible vectorizer types - one for the model being used to make the prediction and the other for the data on which the predictions are to be made. It also adds new tests for previously unhandled combinations.

For a detailed discussion of this, please refer to the original issue #414.

@desilinguist desilinguist added this to the 1.5.3 milestone Dec 12, 2018
@desilinguist desilinguist self-assigned this Dec 12, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

8 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 92.464% when pulling 6cfa1d2 on feature-hasher-mismatched-bins into 8a6e329 on master.

@coveralls
Copy link

coveralls commented Dec 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 92.499% when pulling e01b568 on feature-hasher-mismatched-bins into 8a6e329 on master.

jbiggsets
jbiggsets reviewed Dec 12, 2018
View reviewed changes
skll/learner.py Outdated Show resolved Hide resolved
@desilinguist desilinguist merged commit 5318f29 into master Dec 12, 2018
@desilinguist desilinguist deleted the feature-hasher-mismatched-bins branch December 12, 2018 20:23
@desilinguist desilinguist mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiggsets jbiggsets jbiggsets approved these changes

@mulhod mulhod mulhod approved these changes

@Lguyogiro Lguyogiro Awaiting requested review from Lguyogiro

Assignees

@desilinguist desilinguist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desilinguist @coveralls @mulhod @jbiggsets