Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 #6

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Swift 4 #6

merged 3 commits into from
Mar 23, 2018

Conversation

intellitour
Copy link
Contributor

Conversion to Swift 4.

@intellitour
Copy link
Contributor Author

intellitour commented Mar 1, 2018

Resolves #5

@Edudjr
Copy link
Owner

Edudjr commented Mar 1, 2018

@intellitour Thank you for taking a time on this issue!
However, the tests did fail on travis :/

Testing failed:
“Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
** TEST FAILED **
The following build commands failed:
Check dependencies
(1 failure)

I can't take a look on it right now, but I think it is because of the osx image on the config file:

{
"osx_image": "xcode8.1",
"language": "objective-c",
"xcode_workspace": "Example/TLCustomMask.xcworkspace",
"xcode_scheme": "TLCustomMask-Example",
"xcode_sdk": "iphonesimulator10.1",
"script": [
"xcodebuild test -workspace Example/TLCustomMask.xcworkspace -scheme TLCustomMask-Example -destination 'platform=iOS Simulator,name=iPhone 7,OS=10.1' ONLY_ACTIVE_ARCH=NO | xcpretty"
],
"os": "osx"
}

I hope I can get into this until the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants